From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49739C433EF for ; Thu, 7 Oct 2021 18:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EE1361248 for ; Thu, 7 Oct 2021 18:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243452AbhJGSFc (ORCPT ); Thu, 7 Oct 2021 14:05:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243333AbhJGSFc (ORCPT ); Thu, 7 Oct 2021 14:05:32 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3EE9C061760 for ; Thu, 7 Oct 2021 11:03:38 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so8491889ota.6 for ; Thu, 07 Oct 2021 11:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=UqU2sc6nimwttVNTsN+KoIq0D+bxjGjE0Uy7w4zSjso=; b=jLbW+7kkLTNwDo7nzsbCqMtw9ge068L0fVwd4nYZ32DtCDgR3hrMERyqPF8XokXjKM gGvLUrYZf7iFOiN1n2xwIsANaEuHWtjXxisOvMsRXdB3vug5TsidLpUHrzXyRP1KVZ7S nx3EaPhp3M0WGPkZEFcQG+oB01yueTwuhQ5W0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=UqU2sc6nimwttVNTsN+KoIq0D+bxjGjE0Uy7w4zSjso=; b=RR1Um4aCTnGz4v8sWAZ91cKbaqudDGy79V6FS5PNj/oILHkL+jMRfOEADnOignfO9k XSfDx7+rqQsj6hB/QJ8XC/q+XaL4drnhw/srvzz8+ueLCTEsi7U/NgcVd7XzAOZkbZuw ioaSCwJS/w9hxGjz1lJpyRAC7lG3qo78rpuUmtiKqtC9llWBqJ3gGTdfQkplQPS+Diba SkYm2oXNTlti0NC/rk7S2WChIYg5EnHF649pMsF9d6HfxlX4b2rOuBGHXv6ycmY7vR9L 3wowYEQ+0twsFbkB3FfjBigbSNVSWxbMwI1c79YkEvruNzIAZFXIuGYFsU1nUHofTVEl ffyA== X-Gm-Message-State: AOAM530oN1Jt+x4DiXyZfl9arH4hnTqCcgsciis1QJpwBaVLmPzZkZxX 4+X81ny4s06gLyG3N+vTYSqAoZoTKVyw54iz3OuCRQ== X-Google-Smtp-Source: ABdhPJzdP57QnKdUaciIKhWDyQMB6RtxGohINlseRKeMlntrQwhQiwnOaiAxp80/FctFi0Fd4EUCp1h/9sGJoPkWh6k= X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr5000139otn.126.1633629818067; Thu, 07 Oct 2021 11:03:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Oct 2021 14:03:37 -0400 MIME-Version: 1.0 In-Reply-To: <1633628923-25047-5-git-send-email-pmaliset@codeaurora.org> References: <1633628923-25047-1-git-send-email-pmaliset@codeaurora.org> <1633628923-25047-5-git-send-email-pmaliset@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 7 Oct 2021 14:03:37 -0400 Message-ID: Subject: Re: [PATCH v12 4/5] PCI: qcom: Add a flag in match data along with ops To: Prasad Malisetty , agross@kernel.org, bhelgaas@google.com, bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, svarbanov@mm-sol.com Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org, sallenki@codeaurora.org, manivannan.sadhasivam@linaro.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Prasad Malisetty (2021-10-07 10:48:42) > Add pipe_clk_need_muxing flag in match data and configure This commit text isn't accurate. The flag isn't added in this patch anymore. Same goes for the commit title/subject. Can you please update it to say something like "Point match data to config struct"? > If the platform needs to switch pipe_clk_src. > > Signed-off-by: Prasad Malisetty > --- Otherwise code looks fine: Reviewed-by: Stephen Boyd