From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08C0C433EF for ; Tue, 10 May 2022 17:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348382AbiEJRtP (ORCPT ); Tue, 10 May 2022 13:49:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344641AbiEJRtP (ORCPT ); Tue, 10 May 2022 13:49:15 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53F1E2C13FE for ; Tue, 10 May 2022 10:45:17 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-d6e29fb3d7so19160595fac.7 for ; Tue, 10 May 2022 10:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=8K1zkhTCYeR9WcVMzPAvt0Uq64CTD5BQFWDSVQ6PKj0=; b=a1yGwtdIAQwDX4lYDbGgLXBT/rSwyOK44saKPh2C4pHNvAzvA4vsxiVA/fztJliTTw ZcDD7oDWPo/GPQ48ugUfDSKWkDJK/J0aMDY/168wDKgVBel9S+p+rc9Mlun/kAiI6FRz LUBcvjnVNajpFpk0PYTjD/ZFgFRWS8eTClIrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=8K1zkhTCYeR9WcVMzPAvt0Uq64CTD5BQFWDSVQ6PKj0=; b=OfRmfouCd/IeKGu7Pzpkt84NeXdbLujTQtjHky0P5f28WuLqt2WxUVDBTA6D8UGb2T bWW6OA9Vtid2PwEtNPlH2yrUwzbuxpj1WOm08MBR7Leu6I8diWJT+fd/myP0QsZtLNz7 AbQYeqcF6zxkRQF8VGWMqJgqNacXymlPy7HpgB+GULM7DeZFn8u9AEYdoBwbSdawZZEx Wx9ZwDXku/ltXxOoK0YaOQn7KjeiTjZYEMoK4wu7b7zgqkICUs+i5P1wx+E8l0/V3d8y 96iDMQYE8U3NsHPsW3NTwNnHKUo0aHnVLnPl0T5REu5rEPVobpFCvyT9BpIimjAfnsFK oyLQ== X-Gm-Message-State: AOAM533R9BSNlD1Bwe5NtC2Gel0PMdkCFLcYLABaYyfTcCqOC5+mt/3o 87lUjfyXZ/bNpBdsCPHYQD5P96lznGxPmEhveCf2FQ== X-Google-Smtp-Source: ABdhPJy80Xq7GF6UWv/g20SQkjrDeaebSEqjwH+sR/FQ/xgRHKGaXoYZV6goWF42ZNdxqDsVe76SnL/yqAh7k4QNyRY= X-Received: by 2002:a05:6870:558e:b0:e1:db7c:26aa with SMTP id n14-20020a056870558e00b000e1db7c26aamr699120oao.63.1652204716102; Tue, 10 May 2022 10:45:16 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 10 May 2022 10:45:15 -0700 MIME-Version: 1.0 In-Reply-To: <20220505104024.v4.2.I71176ebf7e5aebddb211f00e805b32c08376d1be@changeid> References: <20220505104024.v4.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid> <20220505104024.v4.2.I71176ebf7e5aebddb211f00e805b32c08376d1be@changeid> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 10 May 2022 10:45:15 -0700 Message-ID: Subject: Re: [PATCH v4 2/5] arm64: dts: qcom: sc7180: Add mrbland dts files To: "Joseph S. Barrera III" , LKML Cc: Douglas Anderson , Alexandru M Stan , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Joseph S. Barrera III (2022-05-05 10:41:13) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi > new file mode 100644 > index 000000000000..e1c1ea09b690 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi > @@ -0,0 +1,352 @@ [...] > + > +&ap_tp_i2c { > + status = "disabled"; > +}; > + > +&backlight { > + pwms = <&cros_ec_pwm 0>; > +}; > + > +&camcc { > + status = "okay"; > +}; > + > +&dsi0 { > + > + panel: panel@0 { Can we have a note here like in the bridge chip dtsi files that says the compatible is filled in per board? /* Compatible will be filled in per-board */ > + reg = <0>; > + enable-gpios = <&tlmm 87 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vdd_reset_1800>; > + avdd-supply = <&avdd_lcd>; > + avee-supply = <&avee_lcd>; > + pp1800-supply = <&v1p8_mipi>; > + pp3300-supply = <&pp3300_dx_edp>; > + backlight = <&backlight>; > + rotation = <270>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + panel_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + [...] > + > +/* PINCTRL - board-specific pinctrl */ > + > +&tlmm { > + gpio-line-names = "HUB_RST_L", > + "AP_RAM_ID0", [..] > + avee_lcd_en: avee-lcd_en { Same underscore comment as patch #1 > + pinmux { > + pins = "gpio21"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio21"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > +