From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED95E1BF31F for ; Tue, 20 Aug 2024 17:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174391; cv=none; b=UuqqwnWGhP0ACObGGvtikKvpHP0S/76VG4UoFBGS4kwY0bjPx9I2RVVljmxnF6gqP8GZlgXlMjRg94U4iArfQHjh5tgUSko6dDmIk31d6zgI784xvABn6U6C/rmbAu4drqBo+65jU8Ckl+9JBddvlhIdhX9RB8XhIvBWWwdPKcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174391; c=relaxed/simple; bh=iDraRUjl5oL1xgN68Huw+NH/26MmOw5WLPqUrN6J8gU=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=kwQdd0Umlg1IY+SM0WyId35jbXdTTaHCvU+k7m3RN0HxoYtZr0G2TR1kHcWADBBUxMmnHhDdCPvxpSD4zDd8RUU6hN102lj6dREcR6shY5D0dzQucOEJLx10O8y+NnSuvbmEgEZqPkHMY6u+Yc757XzwC6TxxxkWRa+fUkvZZRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=f05BM5sL; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="f05BM5sL" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7a1d81dc0beso381433185a.2 for ; Tue, 20 Aug 2024 10:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724174389; x=1724779189; darn=vger.kernel.org; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:from:to:cc:subject:date:message-id :reply-to; bh=TiyLbBScoOEAyh1b94eZlYoF11C+Y/bEKpA+kMzIp/4=; b=f05BM5sLouj6DITyoyLhldpLXgcY/W5wtdqk33z9CH++3YW7A4x2V2GGDfVrioB6M2 EnkPgQAh09KIoZtD2Qiy/XCu1tFQ9qmmgwi+h+zZERCiowbCq14EqddOHAHEffWgWLHP Hap23Jcnq9cQKrjjdpy3AdpUWVeMzLlmW5sws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724174389; x=1724779189; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TiyLbBScoOEAyh1b94eZlYoF11C+Y/bEKpA+kMzIp/4=; b=wjpClsl30tkilw4JK3YjIf2hJEBH0Ug/sLt8FXTnhBsdYZQl7E7HA7+FDe24oKTrY1 v0K6pwRA3lAISrAVn1BkUer7otlIbN/5baF5CmfTw3GKYI0cUaGWSSefU35sTtm+5kAB cY6fduU4wwQOwR3D0cGfwOZtMnTxCAfs94vy/Q9jUZtAeJGYqYBRNmiAr2N7EbT0wkK3 FiRfroGg8+4rFAcVo67tWAiB9xntawIzk3alcB8WAHAzPwQR76lIjiG1ntBlABo4OPO+ GEp89fLsLNzP7FB/3KuoFfDwhcQW7QjjSpmS3q5qpx+6sJylG4uhzVSC+j/6dVlrmZeR 4Zgw== X-Forwarded-Encrypted: i=1; AJvYcCUc6v2y4uBAHmQXC/smsknuGoE2c8UEglsX1kCXqSa0wpEKQPysY/mNwvaDCsiREIAv2wl7JVtpuWX+@vger.kernel.org X-Gm-Message-State: AOJu0YzlmXh8XcrWRnGMK/X6p+9F2lB0rNSaTj63l/D3oTNN+U8q3xlv UzQrmipxTA505bCczg73TVt0Mn0j59JBHKUapjHsVoKib4VAQL3QpfLiv/OrcAX6HWf15xIaIPH 9DAa2DrCbmlarKuyKxd4xTIHBlbzwztCNKuMA X-Google-Smtp-Source: AGHT+IGvb1y8J9GbBVxSnRA9EXCz4Y2dTYC1BxL8SdlIGlM8BUVy3xXqhZZEkOLtGvt/v6Ls5degXKbKQR8XD+zhGss= X-Received: by 2002:a05:620a:2943:b0:7a3:49dd:2002 with SMTP id af79cd13be357-7a5069d5c63mr1695634285a.55.1724174388818; Tue, 20 Aug 2024 10:19:48 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Aug 2024 10:19:48 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: References: <20240819223834.2049862-1-swboyd@chromium.org> <20240819223834.2049862-6-swboyd@chromium.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 20 Aug 2024 10:19:48 -0700 Message-ID: Subject: Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register() To: Andy Shevchenko Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Douglas Anderson , Pin-yen Lin , Andrzej Hajda , Benson Leung , Conor Dooley , Daniel Vetter , David Airlie , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Guenter Roeck , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lee Jones , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Prashant Malani , Robert Foss , Rob Herring , Thomas Zimmermann , Tzung-Bi Shih , Alexandre Belloni , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , Ivan Orlov , linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org, Mika Westerberg , "Rafael J . Wysocki" , Sakari Ailus , Vinod Koul Content-Type: text/plain; charset="UTF-8" Quoting Andy Shevchenko (2024-08-20 10:16:40) > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), GFP_KERNEL); > > > > + if (!ptr) > > > > + return ERR_PTR(-ENOMEM); > > > > + > > > > + switch_dev = typec_switch_register(parent ,desc); > > (Side note: wrong location of the white space) Thanks. > > > > > + if (!IS_ERR(switch_dev)) { > > (Side note: positive conditional is okay) > > > > > + *ptr = switch_dev; > > > > + devres_add(parent, ptr); > > > > + } else { > > > > + devres_free(ptr); > > > > + } > > > > > > devm_add_action_or_reset() ? > > > > No. We don't want to call the 'action' devm_typec_switch_unregister() > > when it fails because that would unregister a switch that has never been > > registered. > > Hmm... With devm_add_action_or_reset() we first do things and then try to add > them to the managed resources. In that case it won't be like you described. > > What do I miss? > I believe you've missed that this is a wrapper around struct device and the error path is different (put_device() vs. device_unregister()).