From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A23FC433F5 for ; Fri, 20 May 2022 20:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243482AbiETUKe (ORCPT ); Fri, 20 May 2022 16:10:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237646AbiETUKc (ORCPT ); Fri, 20 May 2022 16:10:32 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B960819CEF9 for ; Fri, 20 May 2022 13:10:30 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id v66so11195428oib.3 for ; Fri, 20 May 2022 13:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=wiGaxzYkjsSexTF4OnqKljM8nknmSifQmJXxUrBf0MA=; b=MVgIBoV64tzvV8y9jiIJOSMBnsDd4wm2LVgnLBX7s1HvFwvu0XSCEvVWzQqhbVoX6D 88DBGPkjq+0lWtRWBZwhEfZE7ggUnB7pT22Yf4GhVWCah2hLs6WlQeRPBFFBr4lZBNM7 Dy1qPpV7EiHYKOy5TulR/5ISe/5fF6OCvWo60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=wiGaxzYkjsSexTF4OnqKljM8nknmSifQmJXxUrBf0MA=; b=ORwNsQ0l2IsS+MGnt7CQK5Z6RqYDzULA6es5zHWdgR3nmboll4BlUR5Oj0i4qOfuqK WFsykiDfo5d6pDFWGbD5hZ78akgKARS08j06kc0kNq81BIEF5uqu4zwxml2JLQ0CojWL 3PpZF2ylI9hEzRaZKeYPzEMItjbY0Vyau6M8OAkiI+wSmM0+cyJVVuWx7gLUJTEPlaDh 60vCs6yMY+nhPYGTeNnICP3gDzDkEUpujeA525hFtruCmPYa6ZKdNp/WYdjQxSGued2V XIpeayUN5HxuCrAz62JLKtMy9LPms3jypLTTPstHn9/o1zZxU+R8NBMULc/A5FLcjTec 8Inw== X-Gm-Message-State: AOAM531nme0VRPuex0xoyDPuhHMyVBgEacyHbgxUOdiY7rLKaXDqRtsc TzgzucbZC1zrXGzeuk33zNRVD1ve2h6EEkOyYr5cMQ== X-Google-Smtp-Source: ABdhPJw2ESNASeabzgRPotV7qcOex0oQnU0E59jPuICmZ5pWN67wlKt5uZv6bTFKt/7R/sPtqR9z0wgtCUcJf2Pfkcs= X-Received: by 2002:a05:6808:14c2:b0:326:c129:d308 with SMTP id f2-20020a05680814c200b00326c129d308mr6135411oiw.193.1653077430078; Fri, 20 May 2022 13:10:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 May 2022 13:10:29 -0700 MIME-Version: 1.0 In-Reply-To: <1289c2e4-5607-b515-88b1-f44585e62cd3@quicinc.com> References: <1652978825-5304-1-git-send-email-quic_sibis@quicinc.com> <1652978825-5304-3-git-send-email-quic_sibis@quicinc.com> <1289c2e4-5607-b515-88b1-f44585e62cd3@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 20 May 2022 13:10:29 -0700 Message-ID: Subject: Re: [PATCH v4 2/3] dt-bindings: remoteproc: qcom: Convert SC7280 MSS bindings to YAML To: Sibi Sankar , bjorn.andersson@linaro.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org Cc: ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Sibi Sankar (2022-05-20 11:46:58) > On 5/20/22 4:05 AM, Stephen Boyd wrote: > > Quoting Sibi Sankar (2022-05-19 09:47:04) > >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml > >> new file mode 100644 > >> index 000000000000..a936d84eefa6 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml > >> + resets = <&aoss_reset AOSS_CC_MSS_RESTART>, > >> + <&pdc_reset PDC_MODEM_SYNC_RESET>; > >> + reset-names = "mss_restart", "pdc_reset"; > >> + > >> + qcom,halt-regs = <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; > >> + qcom,ext-regs = <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; > > > > Because it's two items I'd expect: > > > > <&tcsr 0x10000 0x10004>, <&tcsr_mutex 0x26004 0x26008>; > > I guess both the ways work since the driver uses > of_parse_phandle_with_fixed_args. See commit 39bd2b6a3783 ("dt-bindings: Improve phandle-array schemas") for why the way you have it is not preferred.