From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14158C433F5 for ; Thu, 17 Mar 2022 18:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237574AbiCQStM (ORCPT ); Thu, 17 Mar 2022 14:49:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237573AbiCQStM (ORCPT ); Thu, 17 Mar 2022 14:49:12 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA9F0F4B for ; Thu, 17 Mar 2022 11:47:54 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id j83so6548602oih.6 for ; Thu, 17 Mar 2022 11:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=7CADnSEG0Ti+iZs0qZN0+RxSMs7D+LGqsLl8TT3zRNs=; b=FsoaK5rHOjGKnfwXuR7QksXlDeTf304iw3gac11n78eywhTdJkBc5MlQwK4swUBBGl Bfkkx2W1SsdTrPN4oPmQCT5TFigNMnILYi80rI3Zz7ywLeEJgiS8kdBvn07A79qlpxkn 6PA8n2WIH5pUB/Qn+VWg7zMULcwy8ee6Vv3MU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=7CADnSEG0Ti+iZs0qZN0+RxSMs7D+LGqsLl8TT3zRNs=; b=ilsP3R2kxlAdigIVUzQ+zKT2OTCx9b5YAoQJfdMwf6J9Mj8AWbWbufr10Cz+Sps3vz J6ecO12CRo2IVkbbxRuYhbOUzoyMD0z+VAUc8BctvEYp+FiG6fc8BJXIfkEqMDw7mJa/ 7H3kESS8rfaiovoRLmdb9d9rTlWdHV9YGVzGKTvqPc5ECWYWVarCX7x0qr2MWTOwZIQj xFN6mpYNa2512rs38vZ85ElkR5nyMSsp5ZK+QmheEjvbnALZv+SkSwxdlQSTte95UVhS r/PFSW3uKMaPWfmzV0aMOExhG9CBhqZ/hJUXVHyMuQYCzy5EfAcW7OW5Hof/XrAMLyZz 7udQ== X-Gm-Message-State: AOAM530fSLlf3OUAECYskTLfTChLyCzER440DsiX8mgK7i2SLXfkb0o8 fJJYy9s+ug8tfKRBGe4wQ+lVbg473NJMT9B0+Y0nQw== X-Google-Smtp-Source: ABdhPJxmh3VWKdUxkUJ5G7J7ZC7LdNnNqO3T16j7O27A4MHfMxte52Cb5CxAhXTH/hd/nEvGienS2Ync2mtbqFsMz2c= X-Received: by 2002:aca:a9c8:0:b0:2da:45b6:b796 with SMTP id s191-20020acaa9c8000000b002da45b6b796mr2573497oie.193.1647542874252; Thu, 17 Mar 2022 11:47:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 17 Mar 2022 14:47:53 -0400 MIME-Version: 1.0 In-Reply-To: <3828e37f-f8e0-8473-537c-8e47cd5df8c6@kernel.org> References: <20220317005814.2496302-1-swboyd@chromium.org> <20220317005814.2496302-2-swboyd@chromium.org> <3828e37f-f8e0-8473-537c-8e47cd5df8c6@kernel.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 17 Mar 2022 14:47:53 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: chrome: Add ChromeOS fingerprint binding To: Benson Leung , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Rob Herring , devicetree@vger.kernel.org, Guenter Roeck , Douglas Anderson , Craig Hesling , Tom Hughes , Alexandru M Stan , Tzung-Bi Shih Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Krzysztof Kozlowski (2022-03-17 02:34:31) > On 17/03/2022 01:58, Stephen Boyd wrote: > > Add a binding to describe the fingerprint processor found on Chromebooks > > with a fingerprint sensor. > > > > Cc: Rob Herring > > Cc: > > Cc: Guenter Roeck > > Cc: Douglas Anderson > > Cc: Craig Hesling > > Cc: Tom Hughes > > Cc: Alexandru M Stan > > Cc: Tzung-Bi Shih > > Signed-off-by: Stephen Boyd > > --- > > .../bindings/chrome/google,cros-ec-fp.yaml | 85 +++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > > > diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > new file mode 100644 > > index 000000000000..ba4212e6b583 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > Hm, so chrome starts to be its own subsystem? I see USB connector > bindings are already there, instead of usb directory. > > Is there anything special about Chrome that it is equal to subsystem or > architecture? Once second file ends up there, this will encourage more > of such patterns. I don't see a problem. > > > @@ -0,0 +1,85 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/chrome/google,cros-ec-fp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ChromeOS Embedded Fingerprint Controller > > + > > +description: > > + Google's ChromeOS embedded fingerprint controller is a device which > > + implements fingerprint functionality such as unlocking a Chromebook > > + without typing a password. > > + > > +maintainers: > > + - Tom Hughes > > + > > +properties: > > + compatible: > > + const: google,cros-ec-fp > > + > > + reg: > > + maxItems: 1 > > + > > + spi-max-frequency: > > + maximum: 3000000 > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: true > > + boot0-gpios: > > + maxItems: 1 > > + description: Assert for bootloader mode. > > + > > + vdd-supply: true > > + > > + google,cros-ec-spi-pre-delay: > > Use proper unit suffix, so "-us". No need for type then. > This is copy pasted from the cros-ec binding and the driver is already looking for this property. Given that, there's no need to have this here right now as we can always add this to the binding when/if it is needed. I mostly put this here for completeness. I'll remove it.