From: Stephen Boyd <swboyd@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, dianders@chromium.org,
judyhsiao@chromium.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org
Cc: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset
Date: Wed, 9 Feb 2022 16:07:33 -0800 [thread overview]
Message-ID: <CAE-0n538CdY3a64jG556se=AhgJpXr_oENG_spGM29c5gdQRYQ@mail.gmail.com> (raw)
In-Reply-To: <30805a84-b523-842c-d223-bc0d2043fa00@quicinc.com>
Quoting Srinivasa Rao Mandadapu (2022-02-09 05:42:40)
>
> On 2/9/2022 2:38 AM, Stephen Boyd wrote:
> > Quoting Srinivasa Rao Mandadapu (2022-02-08 07:34:12)
> >> &qspi_cs0 {
> >> bias-disable;
> >> @@ -491,6 +524,13 @@
> >> };
> >>
> >> &tlmm {
> >> + amp_en: amp-en {
> >> + pins = "gpio63";
> >> + function = "gpio";
> >> + bias-disable;
> > Is there an external pull?
> I think no external pull. In trogdor mentioned bias-pull-down but you
> suggested to remove it.
Maybe on trogdor there was an external pull inside the amp that this pin
is connected to? Usually we have a comment like /* Has external
pull-{up,down} */ so please add that here depending on which way the
pull goes.
next prev parent reply other threads:[~2022-02-10 2:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 15:34 [PATCH v2 0/3] Add lpass pin control support for audio on sc7280 based targets Srinivasa Rao Mandadapu
2022-02-08 15:34 ` [PATCH v2 1/3] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset Srinivasa Rao Mandadapu
2022-02-08 21:08 ` Stephen Boyd
2022-02-09 13:42 ` Srinivasa Rao Mandadapu
2022-02-10 0:07 ` Stephen Boyd [this message]
2022-02-10 14:01 ` Srinivasa Rao Mandadapu
2022-02-08 15:34 ` [PATCH v2 2/3] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Srinivasa Rao Mandadapu
2022-02-08 21:11 ` Stephen Boyd
2022-02-09 14:01 ` Srinivasa Rao Mandadapu
2022-02-10 0:05 ` Stephen Boyd
2022-02-10 14:27 ` Srinivasa Rao Mandadapu
2022-02-08 15:34 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add wcd9380 pinmux Srinivasa Rao Mandadapu
2022-02-08 21:12 ` Stephen Boyd
2022-02-09 14:26 ` Srinivasa Rao Mandadapu
2022-02-10 0:03 ` Stephen Boyd
2022-02-10 14:29 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n538CdY3a64jG556se=AhgJpXr_oENG_spGM29c5gdQRYQ@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_potturu@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).