devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Gwendal Grignou <gwendal@chromium.org>,
	jic23@kernel.org, robh+dt@kernel.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/8] dt-bindings: iio: sx9324: Add internal compensation resistor setting
Date: Tue, 22 Mar 2022 07:59:18 +0100	[thread overview]
Message-ID: <CAE-0n53YaBBKgEDAd1A0nHHacVeE8iK7jOuxtPqAvhSUsKDU0w@mail.gmail.com> (raw)
In-Reply-To: <20220322062504.1019504-6-gwendal@chromium.org>

Quoting Gwendal Grignou (2022-03-21 23:25:01)
> Allow setting the internal resistor used for compensation.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes since v1:
> - Suffix field with kOhms unit.

That's not done here though. I guess there aren't any units.

>
>  .../bindings/iio/proximity/semtech,sx9324.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> index 8fbea71823e76..b5f59038f9dd7 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> @@ -126,6 +126,15 @@ properties:
>        UINT_MAX (4294967295) represents infinite. Other values
>        represent 1-1/N.
>
> +  semtech,int-comp-resistor:
> +    description:
> +      Internal resistor setting for compensation.
> +    enum:
> +      - lowest
> +      - low
> +      - high
> +      - highest
> +
>    semtech,input-precharge-resistor-kohms:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      default: 4
> @@ -165,6 +174,7 @@ examples:
>          semtech,ph01-proxraw-strength = <2>;
>          semtech,ph23-proxraw-strength = <2>;
>          semtech,avg-pos-strength = <64>;
> +        semtech,int-comp-resistor = "lowest";
>          semtech,input-precharge-resistor-kohms = <2>;
>        };
>      };
> --
> 2.35.1.894.gb6a874cedc-goog
>

  reply	other threads:[~2022-03-22  6:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  6:24 [PATCH v2 0/8] Add settings for precharge and internal resistor Gwendal Grignou
2022-03-22  6:24 ` [PATCH v2 1/8] iio: sx9324: Fix default precharge internal resistance register Gwendal Grignou
2022-03-22  6:50   ` Stephen Boyd
2022-03-22  6:24 ` [PATCH v2 2/8] iio: sx9324: Fix register field spelling Gwendal Grignou
2022-03-22  6:50   ` Stephen Boyd
2022-03-22  6:24 ` [PATCH v2 3/8] dt-bindings: iio: sx9324: Add precharge resistor setting Gwendal Grignou
2022-03-22  6:51   ` Stephen Boyd
2022-03-25 22:01     ` Gwendal Grignou
2022-03-22  6:25 ` [PATCH v2 4/8] iio: sx9324: Add precharge internal resistance setting Gwendal Grignou
2022-03-22  6:25 ` [PATCH v2 5/8] dt-bindings: iio: sx9324: Add internal compensation resistor setting Gwendal Grignou
2022-03-22  6:59   ` Stephen Boyd [this message]
2022-03-22  6:25 ` [PATCH v2 6/8] iio: sx9324: Add Setting for internal compensation resistor Gwendal Grignou
2022-03-22  6:59   ` Stephen Boyd
2022-03-22  6:25 ` [PATCH v2 7/8] dt-bindings: iio: sx9360: Add precharge resistor setting Gwendal Grignou
2022-03-22  6:25 ` [PATCH v2 8/8] iio: sx9360: Add pre-charge " Gwendal Grignou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE-0n53YaBBKgEDAd1A0nHHacVeE8iK7jOuxtPqAvhSUsKDU0w@mail.gmail.com \
    --to=swboyd@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).