From: Evan Green <evgreen@chromium.org>
To: swboyd@chromium.org
Cc: Lina Iyer <ilina@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, msivasub@codeaurora.org
Subject: Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs
Date: Mon, 09 Apr 2018 20:42:32 +0000 [thread overview]
Message-ID: <CAE=gft4uBMknENW5o7Rr+ZPQYWUBRBRzAPdvy2=8wGDMMV4CVw@mail.gmail.com> (raw)
In-Reply-To: <152305660223.94378.422604779280814924@swboyd.mtv.corp.google.com>
On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd <swboyd@chromium.org> wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> > Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > + reserved-memory {
> > + [...]
> > + qcom,cmd-db@85fe0000 {
> Nitpick: This may want to be called 'memory@85fe0000' because we prefer
> generic node names.
Another nit: the cmd-db region seems to need "no-map" to make the example
actually work.
Reviewed-by: Evan Green <evgreen@chromium.org>
-Evan
next prev parent reply other threads:[~2018-04-09 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180406151356.7818-1-ilina@codeaurora.org>
2018-04-06 15:13 ` [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs Lina Iyer
2018-04-06 23:16 ` Stephen Boyd
2018-04-09 20:42 ` Evan Green [this message]
2018-04-10 14:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft4uBMknENW5o7Rr+ZPQYWUBRBRzAPdvy2=8wGDMMV4CVw@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).