From: Evan Green <evgreen@chromium.org>
To: cang@codeaurora.org
Cc: subhashj@codeaurora.org, asutoshd@codeaurora.org,
vivek.gautam@codeaurora.org, Manu Gautam <mgautam@codeaurora.org>,
kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v7 2/4] phy: General struct and field cleanup
Date: Wed, 27 Jun 2018 13:17:42 -0700 [thread overview]
Message-ID: <CAE=gft64dGEMi5QTCzKp7Eg9T=QDL3SbohiAuZBFJkeiOZK3og@mail.gmail.com> (raw)
In-Reply-To: <20180619083647.10116-3-cang@codeaurora.org>
On Tue, Jun 19, 2018 at 1:38 AM Can Guo <cang@codeaurora.org> wrote:
>
> Move MSM8996 specific PHY vreg list struct name to a genernal one as it is
> used by all PHYs. Add a specific field to handle dual lane situation.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
I'm not a PHY expert, so I can't say much about the mechanics or
ramifications of the is_dual_lane_phy change is, but for at least the
sanity of the patch, here's my tag:
Reviewed-by: Evan Green <evgreen@chromium.org>
next prev parent reply other threads:[~2018-06-27 20:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 8:36 [PATCH v7 0/4] Support for Qualcomm UFS QMP PHY on SDM845 Can Guo
2018-06-19 8:36 ` [PATCH v7 1/4] phy: Update PHY power control sequence Can Guo
2018-06-28 3:49 ` Manu Gautam
2018-07-02 17:00 ` Vivek Gautam
2018-07-25 20:26 ` Evan Green
2018-06-19 8:36 ` [PATCH v7 2/4] phy: General struct and field cleanup Can Guo
2018-06-27 20:17 ` Evan Green [this message]
2018-06-28 3:48 ` Manu Gautam
2018-07-02 6:42 ` Vivek Gautam
2018-06-19 8:36 ` [PATCH v7 3/4] phy: Add QMP phy based UFS phy support for sdm845 Can Guo
2018-06-27 20:17 ` Evan Green
2018-07-06 8:01 ` cang
2018-06-28 3:46 ` Manu Gautam
2018-06-19 8:36 ` [PATCH v7 4/4] dt-bindings: phy-qcom-qmp: Add UFS phy compatible string " Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft64dGEMi5QTCzKp7Eg9T=QDL3SbohiAuZBFJkeiOZK3og@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=subhashj@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).