From: Ajay kumar <ajaynumb@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Stephan van Schaik <stephan@synkhronix.com>,
Vincent Palatin <vpalatin@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
Ajay Kumar <ajaykumar.rs@samsung.com>
Subject: Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree
Date: Thu, 31 Jul 2014 15:19:53 +0530 [thread overview]
Message-ID: <CAEC9eQNuPN+WiKGOtCosCwcR48MNawQL7dU4S8=dbA4eFXB_-w@mail.gmail.com> (raw)
In-Reply-To: <53DA0BAA.8090000@suse.de>
Hi Andreas,
On Thu, Jul 31, 2014 at 2:56 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 30.07.2014 15:50, schrieb Andreas Färber:
>> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
>> new file mode 100644
>> index 000000000000..bcca892bf2ff
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-spring.dts
> [...]
>> +&pinctrl_0 {
>> + dp_hpd_gpio: dp-hpd-gpio {
>> + samsung,pins = "gpc3-0";
>> + samsung,pin-function = <1>;
>
> Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0.
Right, this should be 0.
>> + samsung,pin-pud = <3>;
>> + samsung,pin-drv = <0>;
>> + };
>
> Seeing that Ajay called this node dp-hdp, it should probably be an override?
dp_hpd should be enough. I will keep the same name for peach boards.
dp_hpd: dp-hpd {
.
.
.
};
Ajay
next prev parent reply other threads:[~2014-07-31 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 13:50 [PATCH v3 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-30 13:50 ` [PATCH v3 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-07-30 13:50 ` [PATCH v3 2/4] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-07-30 13:50 ` [PATCH v3 3/4] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-07-30 13:50 ` [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree Andreas Färber
[not found] ` <1406728244-5105-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2014-07-31 9:26 ` Andreas Färber
2014-07-31 9:49 ` Ajay kumar [this message]
[not found] ` <CAEC9eQNuPN+WiKGOtCosCwcR48MNawQL7dU4S8=dbA4eFXB_-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-31 9:53 ` Andreas Färber
2014-07-31 10:01 ` Ajay kumar
2014-07-30 14:17 ` [PATCH v3 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEC9eQNuPN+WiKGOtCosCwcR48MNawQL7dU4S8=dbA4eFXB_-w@mail.gmail.com' \
--to=ajaynumb@gmail.com \
--cc=afaerber@suse.de \
--cc=ajaykumar.rs@samsung.com \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stephan@synkhronix.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).