From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay kumar <ajaynumb@gmail.com>
Subject: Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree
Date: Thu, 31 Jul 2014 15:19:53 +0530
Message-ID: <CAEC9eQNuPN+WiKGOtCosCwcR48MNawQL7dU4S8=dbA4eFXB_-w@mail.gmail.com>
References: <1406728244-5105-1-git-send-email-afaerber@suse.de>
	<1406728244-5105-5-git-send-email-afaerber@suse.de>
	<53DA0BAA.8090000@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <53DA0BAA.8090000@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Stephan van Schaik <stephan@synkhronix.com>, Vincent Palatin <vpalatin@chromium.org>, Doug Anderson <dianders@chromium.org>, Javier Martinez Canillas <javier.martinez@collabora.co.uk>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Russell King <linux@arm.linux.org.uk>, Ben Dooks <ben-linux@fluff.org>, Kukjin Kim <kgene.kim@samsung.com>, LKML <linux-kernel@vger.kernel.org>, Ajay Kumar <ajaykumar.rs@samsung.com>
List-Id: devicetree@vger.kernel.org

Hi Andreas,

On Thu, Jul 31, 2014 at 2:56 PM, Andreas F=C3=A4rber <afaerber@suse.de>=
 wrote:
> Am 30.07.2014 15:50, schrieb Andreas F=C3=A4rber:
>> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot=
/dts/exynos5250-spring.dts
>> new file mode 100644
>> index 000000000000..bcca892bf2ff
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-spring.dts
> [...]
>> +&pinctrl_0 {
>> +     dp_hpd_gpio: dp-hpd-gpio {
>> +             samsung,pins =3D "gpc3-0";
>> +             samsung,pin-function =3D <1>;
>
> Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0.
Right, this should be 0.

>> +             samsung,pin-pud =3D <3>;
>> +             samsung,pin-drv =3D <0>;
>> +     };
>
> Seeing that Ajay called this node dp-hdp, it should probably be an ov=
erride?
dp_hpd should be enough. I will keep the same name for peach boards.
dp_hpd: dp-hpd {
=2E
=2E
=2E
};

Ajay