From: Bin Meng <bmeng.cn@gmail.com>
To: Zong Li <zong.li@sifive.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
krzysztof.kozlowski@canonical.com,
Conor Dooley <conor.dooley@microchip.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Bin Meng <bin.meng@windriver.com>,
Green Wan <green.wan@sifive.com>,
vkoul@kernel.org, dmaengine@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v8 4/4] dmaengine: sf-pdma: Get number of channel by device tree
Date: Tue, 29 Mar 2022 09:35:49 +0800 [thread overview]
Message-ID: <CAEUhbmU9ZYniNNv-WYmeTfxh5MXN1NB_fL32FiOxPpx3d2e1_A@mail.gmail.com> (raw)
In-Reply-To: <f08a95b6582a51712c5b2c3cb859136d07bfa8b9.1648461096.git.zong.li@sifive.com>
On Mon, Mar 28, 2022 at 7:38 PM Zong Li <zong.li@sifive.com> wrote:
>
> It currently assumes that there are always four channels, it would
> cause the error if there is actually less than four channels. Change
> that by getting number of channel from device tree.
>
> For backwards-compatibility, it uses the default value (i.e. 4) when
> there is no 'dma-channels' information in dts.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> drivers/dma/sf-pdma/sf-pdma.c | 24 ++++++++++++++++--------
> drivers/dma/sf-pdma/sf-pdma.h | 8 ++------
> 2 files changed, 18 insertions(+), 14 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
next prev parent reply other threads:[~2022-03-29 1:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 9:52 [PATCH v8 0/4] Determine the number of DMA channels by 'dma-channels' property Zong Li
2022-03-28 9:52 ` [PATCH v8 1/4] dt-bindings: dma-engine: sifive,fu540: Add dma-channels property and modify compatible Zong Li
2022-03-29 1:35 ` Bin Meng
2022-03-28 9:52 ` [PATCH v8 2/4] riscv: dts: " Zong Li
2022-03-29 1:35 ` Bin Meng
2022-03-28 9:52 ` [PATCH v8 3/4] riscv: dts: rename the node name of dma Zong Li
2022-03-29 1:35 ` Bin Meng
2022-03-28 9:52 ` [PATCH v8 4/4] dmaengine: sf-pdma: Get number of channel by device tree Zong Li
2022-03-29 1:35 ` Bin Meng [this message]
2022-03-31 1:06 ` [PATCH v8 0/4] Determine the number of DMA channels by 'dma-channels' property Zong Li
2022-03-31 3:15 ` Palmer Dabbelt
2022-03-31 5:21 ` Vinod Koul
2022-03-31 5:54 ` Palmer Dabbelt
2022-03-31 22:42 ` Palmer Dabbelt
2022-04-01 5:50 ` Zong Li
2022-04-08 8:03 ` Zong Li
2022-04-08 13:13 ` Vinod Koul
2022-04-11 2:51 ` Zong Li
2022-04-11 10:48 ` Vinod Koul
2022-04-11 11:43 ` Zong Li
2022-04-20 0:18 ` Palmer Dabbelt
2022-04-20 14:25 ` Rob Herring
2022-04-21 1:07 ` Zong Li
2022-04-21 2:49 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmU9ZYniNNv-WYmeTfxh5MXN1NB_fL32FiOxPpx3d2e1_A@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=bin.meng@windriver.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=green.wan@sifive.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).