* [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog
@ 2022-07-28 15:39 Pin-yen Lin
2022-07-28 17:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Pin-yen Lin @ 2022-07-28 15:39 UTC (permalink / raw)
To: Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel
Cc: Eizan Miyamoto, Evan Benn, Hsin-Yi Wang, Pin-yen Lin,
Krzysztof Kozlowski, Rob Herring, devicetree
Switch to SMC watchdog because we need direct control of HW watchdog
registers from kernel. The corresponding firmware was uploaded in
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v3:
- Remove /delete-node/ and create a new node for SMC watchdog.
Changes in v2:
- Move the modifications to mt8173-elm.dtsi and add some comments.
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index e21feb85d822..fc8203297bac 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
};
};
};
+
+
+ smc_watchdog {
+ compatible = "arm,smc-wdt";
+ };
+};
+
+/*
+ * Disable the original MMIO watch dog and switch to the SMC watchdog, which
+ * operates on the same MMIO.
+ */
+&watchdog {
+ status = "disabled";
};
&mfg_async {
--
2.37.1.359.gd136c6c3e2-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog
2022-07-28 15:39 [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog Pin-yen Lin
@ 2022-07-28 17:54 ` Krzysztof Kozlowski
2022-07-29 3:00 ` Pin-yen Lin
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-28 17:54 UTC (permalink / raw)
To: Pin-yen Lin, Matthias Brugger, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Eizan Miyamoto, Evan Benn, Hsin-Yi Wang, Krzysztof Kozlowski,
Rob Herring, devicetree
On 28/07/2022 17:39, Pin-yen Lin wrote:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> ---
>
> Changes in v3:
> - Remove /delete-node/ and create a new node for SMC watchdog.
>
> Changes in v2:
> - Move the modifications to mt8173-elm.dtsi and add some comments.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index e21feb85d822..fc8203297bac 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> };
> };
> };
> +
> +
Why?
> + smc_watchdog {
No, you need to read the comment you receive one more time. So to be
clear: "watchdog"
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog
2022-07-28 17:54 ` Krzysztof Kozlowski
@ 2022-07-29 3:00 ` Pin-yen Lin
0 siblings, 0 replies; 3+ messages in thread
From: Pin-yen Lin @ 2022-07-29 3:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel,
Eizan Miyamoto, Evan Benn, Hsin-Yi Wang, Krzysztof Kozlowski,
Rob Herring, devicetree
On Fri, Jul 29, 2022 at 1:54 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 28/07/2022 17:39, Pin-yen Lin wrote:
> > Switch to SMC watchdog because we need direct control of HW watchdog
> > registers from kernel. The corresponding firmware was uploaded in
> > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
> >
> > Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Remove /delete-node/ and create a new node for SMC watchdog.
> >
> > Changes in v2:
> > - Move the modifications to mt8173-elm.dtsi and add some comments.
> >
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > index e21feb85d822..fc8203297bac 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> > };
> > };
> > };
> > +
> > +
>
> Why?
>
> > + smc_watchdog {
>
> No, you need to read the comment you receive one more time. So to be
> clear: "watchdog"
>
Ah I see. I'll fix this in v4.
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-29 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-28 15:39 [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog Pin-yen Lin
2022-07-28 17:54 ` Krzysztof Kozlowski
2022-07-29 3:00 ` Pin-yen Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).