From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Baluta Subject: Re: [PATCH 1/4] arm64: dts: imx8mq: Fix the fsl,imx8mq-sdma compatible string Date: Fri, 29 Mar 2019 13:20:00 +0200 Message-ID: References: <20190328133828.20999-1-angus@akkea.ca> <20190328133828.20999-2-angus@akkea.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Aisheng Dong Cc: "Angus Ainslie (Purism)" , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Dan Williams , Vinod Koul , Lucas Stach , Carlo Caione , Daniel Baluta , =?UTF-8?Q?Guido_G=C3=BCnther?= , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dmaengin List-Id: devicetree@vger.kernel.org On Fri, Mar 29, 2019 at 11:11 AM Aisheng Dong wrote: > > > From: Angus Ainslie (Purism) [mailto:angus@akkea.ca] > > Sent: Thursday, March 28, 2019 9:38 PM > > > > Fix a typo in the compatible string > > > > Signed-off-by: Angus Ainslie (Purism) > > --- > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > index 81d5ce1b1ec1..07099f82965e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > @@ -720,7 +720,7 @@ > > }; > > > > sdma1: sdma@30bd0000 { > > - compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; > > + compatible = "fsl,mx8mq-sdma","fsl,imx7d-sdma"; > > This is a bit strange. > If binding doc says like that, probably we'd better fix the typo in binding doc > to use the same style. Oh, indeed. Angus, shouldn't this be fsl,imx8mq-sdma instead of fsl,mx8mq-sdma. I was just paying attention to the extra space in my patch.