From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vishnu Patekar Subject: Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation Date: Mon, 11 May 2015 14:23:54 +0530 Message-ID: References: <1431240383-12763-1-git-send-email-vishnupatekar0510@gmail.com> <1431240383-12763-4-git-send-email-vishnupatekar0510@gmail.com> <20150510101750.GC11057@lukather> Reply-To: vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150510101750.GC11057@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, Linus Walleij , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Hans de Goede , Chen-Yu Tsai , Jens Kuske , Arnd Bergmann , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi, On Sun, May 10, 2015 at 3:47 PM, Maxime Ripard wrote: > Hi, > > On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote: >> A33 clock control unit is similar to A23. >> >> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE >> to get it compiled for A33. > > That commit log doesn't make any sense. > > What you're doing isn't about whether or not that will be compiled, > but whether you're registering the clocks and which clocks you > protect. Actually, It's just registering the a33 clocks and reusing a23 code. nothing to do with compile. I'll correct it in next patch version. > >> Signed-off-by: VishnuPatekar > > Isn't it supposed to have a space in the middle of your name, just > like you have in your mail address? Yes, There should be space. > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com