devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>,
	y@qualcomm.com, dri-devel <dri-devel@lists.freedesktop.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	freedreno <freedreno@lists.freedesktop.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Kalyan Thota <kalyant@codeaurora.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Krishna Manikandan <mkrishn@codeaurora.org>,
	hywu@google.com, midean@google.com
Subject: Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume
Date: Mon, 22 Mar 2021 18:58:01 -0700	[thread overview]
Message-ID: <CAF6AEGtkMD19ZFbs7TxQ6wVn-DMgHQbpDokwRvkL1wTgqMK2ZA@mail.gmail.com> (raw)
In-Reply-To: <YFk6AINTcg2S6vDe@google.com>

On Mon, Mar 22, 2021 at 5:44 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote:
> > From: Kalyan Thota <kalyant@codeaurora.org>
> >
> > DPU runtime resume will request for a min vote on the AXI bus as
> > it is a necessary step before turning ON the AXI clock.
> >
> > The change does below
> > 1) Move the icc path set before requesting runtime get_sync.
> > 2) remove the dependency of hw catalog for min ib vote
> > as it is initialized at a later point.
> >
> > Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>
>
> Confirmed that this fixes a bunch of warnings at boot on SC7180 when
> (out-of-tree) camera support is enabled:
>
>   [    1.832228] gcc_disp_hf_axi_clk status stuck at 'off'
>   [    2.118292] gcc_disp_hf_axi_clk status stuck at 'off'
>   [    2.442383] gcc_disp_hf_axi_clk already disabled
>   [    2.750054] gcc_disp_hf_axi_clk already unprepared
>   [    3.154835] gcc_disp_hf_axi_clk already disabled
>   [    3.421835] gcc_disp_hf_axi_clk already unprepared
>
> Tested-by: Matthias Kaehlcke <mka@chromium.org>

thanks for testing on the setup which had this issue.. I've pushed to msm-next

BR,
-R

  reply	other threads:[~2021-03-23  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  9:17 [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume Kalyan Thota
2021-03-23  0:44 ` Matthias Kaehlcke
2021-03-23  1:58   ` Rob Clark [this message]
2021-03-30 18:34 ` Steev Klimaszewski
2021-03-31 12:34   ` [Freedreno] " kalyan_t
2021-03-31 17:39     ` Steev Klimaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF6AEGtkMD19ZFbs7TxQ6wVn-DMgHQbpDokwRvkL1wTgqMK2ZA@mail.gmail.com \
    --to=robdclark@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=hywu@google.com \
    --cc=kalyan_t@codeaurora.org \
    --cc=kalyant@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=midean@google.com \
    --cc=mka@chromium.org \
    --cc=mkrishn@codeaurora.org \
    --cc=y@qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).