From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Subject: Re: [PATCH 10/14] arm64: dts: meson-axg: add linein codec Date: Wed, 25 Jul 2018 21:18:27 +0200 Message-ID: References: <20180724125238.14567-1-jbrunet@baylibre.com> <20180724125238.14567-11-jbrunet@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180724125238.14567-11-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: jbrunet@baylibre.com Cc: khilman@baylibre.com, carlo@caione.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Jerome, On Tue, Jul 24, 2018 at 3:09 PM Jerome Brunet wrote: > > Add the es7241 analog to digital converter which is fed by the > lienin jack of the s400 > > Signed-off-by: Jerome Brunet > --- > arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > index 7489b88f27d7..fb101a1c6660 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > @@ -178,6 +178,16 @@ > gpios = <&gpio_speaker 2 0>; > }; > }; > + > + linein: audio-codec@0 { there is a unit-address but no reg property - I am wondering if this is allowed? for the regulators we're using regulator- instead of regulator@ (this applies to other patches in this series as well) > + #sound-dai-cells = <0>; > + compatible = "everest,es7241"; > + VDDA-supply = <&vcc_3v3>; > + VDDP-supply = <&vcc_3v3>; > + VDDD-supply = <&vcc_3v3>; > + status = "okay"; > + sound-name-prefix = "Linein"; SPDIF output uses capital letters "SPDIFOUT" I am not familiar with the sound subsystem (thus I'm not sure where this shows up) so I am wondering if the naming should be consistent? Regards Martin