From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings
Date: Sat, 22 Dec 2018 17:40:11 +0100 [thread overview]
Message-ID: <CAFBinCBUm+Js1-ZabP9bSmYE0qG9Z9gYr-ua+ayDyPOdXUsEyQ@mail.gmail.com> (raw)
In-Reply-To: <20181219233519.35287-1-khilman@baylibre.com>
Hi Kevin,
On Thu, Dec 20, 2018 at 12:35 AM Kevin Hilman <khilman@baylibre.com> wrote:
>
> Add new vendor for amediatech, and initial board: x96-max
as we have seen there is no "amediatech" branding anywhere on the board itself
however, FCC gave us a clue about the manufacturer: [0]
can you please add this info to the patch description when re-sending?
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
(with the two comments below)
> Documentation/devicetree/bindings/arm/amlogic.txt | 1 +
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
if Rob is fine with vendor-prefixes.txt being updated together with
adding a new board then I'm as well :)
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
> index 8dbc259081e4..c50b084b6c59 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
> - "amlogic,p281" (Meson gxl s905w)
> - "oranth,tx3-mini" (Meson gxl s905w)
>
> + - "amediatech,x96-max" (Meson gxm s912)
I assume that you'll not only fix the SoC here (G12A) as reported by
Chris Moore but also the ordering
Regards
Martin
[0] https://fccid.io/2AI6D-X96MAX
next prev parent reply other threads:[~2018-12-22 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 23:35 [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings Kevin Hilman
2018-12-19 23:35 ` [PATCH v2 2/2] arm64: dts: meson: add g12a x96 max board Kevin Hilman
2019-01-21 10:43 ` Neil Armstrong
2019-01-31 16:48 ` Kevin Hilman
2018-12-21 22:12 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings Chris Moore
2018-12-21 23:13 ` Kevin Hilman
2019-01-31 16:48 ` Kevin Hilman
2018-12-22 16:40 ` Martin Blumenstingl [this message]
2019-01-31 16:49 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCBUm+Js1-ZabP9bSmYE0qG9Z9gYr-ua+ayDyPOdXUsEyQ@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).