From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: khilman@baylibre.com, robh+dt@kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, christianshewitt@gmail.com,
jian.hu@amlogic.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements
Date: Sat, 5 Dec 2020 14:14:12 +0100 [thread overview]
Message-ID: <CAFBinCCBQupdpm0CmxZo_VeRyk_Kqwqsf+Q66aaxqcNv3hsA9g@mail.gmail.com> (raw)
In-Reply-To: <14754fd95378b78eb9a0a3f8b6bab13f7263c7f1.1606828668.git.stefan@agner.ch>
On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@agner.ch> wrote:
>
> According to the datasheet (Rev. 1.9) the RTL8211F requires at least
> 72ms "for internal circuits settling time" before accessing the PHY
> egisters. This fixes an issue where the Ethernet link doesn't come up
> when using ip link set down/up:
> [ 29.360965] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down
> [ 34.569012] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31)
> [ 34.676732] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma
> [ 34.678874] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed
> [ 34.687850] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
>
> Fixes: 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
with the "registers" typo above fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
prev parent reply other threads:[~2020-12-05 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 13:21 [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements Stefan Agner
2020-12-01 13:21 ` [PATCH v2 2/5] arm64: dts: meson: " Stefan Agner
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-01 13:21 ` [PATCH v2 3/5] ARM: " Stefan Agner
2020-12-05 13:04 ` Martin Blumenstingl
2020-12-07 17:53 ` Stefan Agner
2020-12-01 13:21 ` [PATCH v2 4/5] arm64: dts: meson: g12a: x96-max: " Stefan Agner
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-01 13:21 ` [PATCH v2 5/5] arm64: dts: meson: g12b: w400: " Stefan Agner
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCBQupdpm0CmxZo_VeRyk_Kqwqsf+Q66aaxqcNv3hsA9g@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).