From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Subject: Re: [RFC v2 1/9] serdev: implement parity configuration Date: Tue, 2 Jan 2018 22:16:12 +0100 Message-ID: References: <20180101204217.26165-1-martin.blumenstingl@googlemail.com> <20180101204217.26165-2-martin.blumenstingl@googlemail.com> <4FDCB65A-641A-4134-BAF1-4A777012FDE7@holtmann.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4FDCB65A-641A-4134-BAF1-4A777012FDE7-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marcel Holtmann Cc: Rob Herring , devicetree , "open list:BLUETOOTH DRIVERS" , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland , "Gustavo F. Padovan" , Johan Hedberg , Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Larry Finger , Carlo Caione , Daniel Drake List-Id: devicetree@vger.kernel.org Hi Marcel, Hi Rob, On Tue, Jan 2, 2018 at 12:16 PM, Marcel Holtmann wrot= e: > Hi Martin, > >> Some Bluetooth modules (for example the ones found in Realtek RTL8723BS >> and RTL8723DS) want to communicate with the host with even parity >> enabled. >> Add a new function and the corresponding internal callbacks so parity >> can be configured. This supports enabling and disabling parity as well >> as setting the type to odd or even. >> >> Signed-off-by: Martin Blumenstingl >> --- >> drivers/tty/serdev/core.c | 12 ++++++++++++ >> drivers/tty/serdev/serdev-ttyport.c | 21 +++++++++++++++++++++ >> include/linux/serdev.h | 5 +++++ >> 3 files changed, 38 insertions(+) >> >> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c >> index 1bef39828ca7..d327b02980f5 100644 >> --- a/drivers/tty/serdev/core.c >> +++ b/drivers/tty/serdev/core.c >> @@ -225,6 +225,18 @@ void serdev_device_set_flow_control(struct serdev_d= evice *serdev, bool enable) >> } >> EXPORT_SYMBOL_GPL(serdev_device_set_flow_control); >> >> +void serdev_device_set_parity(struct serdev_device *serdev, bool enable= , >> + bool odd) >> +{ >> + struct serdev_controller *ctrl =3D serdev->ctrl; >> + >> + if (!ctrl || !ctrl->ops->set_parity) >> + return; >> + >> + ctrl->ops->set_parity(ctrl, enable, odd); >> +} >> +EXPORT_SYMBOL_GPL(serdev_device_set_parity); >> + > > this really needs Rob=E2=80=99s ACK before I take the patch. sure I could even live with a NACK in case these two bool parameters are considered to be ugly in that case I would propose an enum with three values: DISABLED, EVEN, ODD so the arguments would look like this: void serdev_device_set_parity(struct serdev_device *serdev, enum parity) Regards Martin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html