Re: [PATCH v4 3/3] ath9k: parse the device configuration from an OF node

[Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>]

On Sun, Jul 10, 2016 at 2:19 AM, Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org> wrote:
> Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes:
>
>> +     if (of_property_read_bool(np, "qca,clk-25mhz"))
>> +             ah->is_clk_25mhz = true;
>> +
>> +     if (of_property_read_bool(np, "qca,disable-2ghz"))
>> +             ah->disable_2ghz = true;
>> +
>> +     if (of_property_read_bool(np, "qca,disable-5ghz"))
>> +             ah->disable_5ghz = true;
>
> This is bike-shedding, but how about
>
>         ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
>         ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
>         ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
I'm fine with either way - I'll simply adhere to the coding style that
the ath9k devs want to use, so just let me know which one you prefer.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html