From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Da Xue <da@lessconfused.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: meson: add g12a x96 max board
Date: Thu, 17 Jan 2019 20:55:34 +0100 [thread overview]
Message-ID: <CAFBinCDfEFH_9pa_ATm-k5OaYMQwVfiGzN6d5dF5dMDGYbqHxg@mail.gmail.com> (raw)
In-Reply-To: <CACdvmAhi92uLcBfzoJeqkC94np8t7wg7ivb3dz11cTvAO5D60w@mail.gmail.com>
On Thu, Jan 10, 2019 at 7:54 PM Da Xue <da@lessconfused.com> wrote:
>
> Hi,
>
> To be on the safe side, I would add the PCB revision number and WiFi module name.
my PCB states: Q5X2 V3.0 18393
> Most of the WiFi modules are from Fn link so simply denoting the AP6356S may be sufficient to distinguish future PCB revisions and wireless modules.
our .dtbs mostly don't care about the WiFi chip (because it can be
auto-detected using the SDIO ID).
however, Bluetooth support on these modules is different because a
different WiFi / Bluetooth combo chip manufacturer also means
different dt-bindings
regarding the .dts name so far we have:
- meson-g12a-x96-max.dts
and your suggestions:
- meson-g12a-x96-max-ap6356s.dts
- meson-g12a-x96-max-3.0-ap6356s.dts
Regards
Martin
next prev parent reply other threads:[~2019-01-17 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 0:26 [PATCH 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings Kevin Hilman
2018-12-19 0:26 ` [PATCH 2/2] arm64: dts: meson: add g12a x96 max board Kevin Hilman
2018-12-19 16:13 ` Peter Korsgaard
2018-12-19 23:31 ` Kevin Hilman
2018-12-22 16:57 ` Martin Blumenstingl
2019-01-08 22:32 ` Martin Blumenstingl
[not found] ` <CACdvmAg3=GmcLOKJ33K6aGks7DRnityd4KiU30qwCb-YWz_EPA@mail.gmail.com>
2019-01-09 22:22 ` Martin Blumenstingl
[not found] ` <CACdvmAhi92uLcBfzoJeqkC94np8t7wg7ivb3dz11cTvAO5D60w@mail.gmail.com>
2019-01-17 19:55 ` Martin Blumenstingl [this message]
2018-12-20 5:38 ` [PATCH 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings Chris Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCDfEFH_9pa_ATm-k5OaYMQwVfiGzN6d5dF5dMDGYbqHxg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=da@lessconfused.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).