From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guodong Xu Subject: Re: [PATCH 2/2] arm64: dts: hi6220: add acpu_sctrl Date: Wed, 16 Aug 2017 11:01:15 +0800 Message-ID: References: <1492478242-16146-1-git-send-email-zhangfei.gao@linaro.org> <1492478242-16146-2-git-send-email-zhangfei.gao@linaro.org> <5992F7FB.9080709@hisilicon.com> <20170815150138.GL22218@golem.pkh.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170815150138.GL22218-Bl/+WD2hOLMHaudFD6lisA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?Q2zDqW1lbnQgQsWTc2No?= Cc: Wei Xu , Zhangfei Gao , Stephen Boyd , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel , Li Pengcheng List-Id: devicetree@vger.kernel.org On Tue, Aug 15, 2017 at 11:01 PM, Cl=C3=A9ment B=C5=93sch wrote: > On Tue, Aug 15, 2017 at 02:32:43PM +0100, Wei Xu wrote: >> Hi Zhangfei, >> >> On 2017/4/18 2:17, Zhangfei Gao wrote: >> > Add acpu_sctrl clock node >> > >> > Signed-off-by: Zhangfei Gao >> > Signed-off-by: Li Pengcheng >> > --- >> > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/bo= ot/dts/hisilicon/hi6220.dtsi >> > index 470461d..710cc34 100644 >> > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> > @@ -262,6 +262,12 @@ >> > #clock-cells =3D <1>; >> > }; >> > >> > + acpu_sctrl: acpu_sctrl@f7032000 { > > I think the unit address is incorrect here (this value has been copied > from the pm controller while it should match the 1st one the reg). > >> > + compatible =3D "hisilicon,hi6220-acpu-sctrl", "sys= con"; >> > + reg =3D <0x0 0xf6504000 0x0 0x1000>; >> > + #clock-cells =3D <1>; >> > + }; >> > + >> > medianoc_ade: medianoc_ade@f4520000 { >> > compatible =3D "syscon"; >> > reg =3D <0x0 0xf4520000 0x0 0x4000>; >> > > > Also I'm sorry I'm going to ask stupid questions: > > - why 's' in "sctrl" while all the other node controllers declared around > seems to use "ctrl"? > > - is it possible to have access to the specs where those addresses can be > found? The only public doc I could find is the "Hi6220V100 Multi-Mode > Application Processor" one where this information doesn't seem present. > That's the only public doc. But if you need, welcome to discuss with me off-line about referencing kernels for hikey. > - is there any work pending adding the pmu counters node (interrupt > GCI_SPI 99) ? AFAIK the ACPU controller added here can be used to enabl= e > the counters. > For hikey PMU, please have a look of this patchset: - https://github.com/96boards/linux/pull/86/commits Discussion is here: - https://discuss.96boards.org/t/performance-monitoring-unit-pmu/293/4 Due to its implementation is not compatible with upstream, this patchset was not upstreamed. If you are interested, welcome to adding them LKML. Appreciate your effort. -Guodong >> >> Thanks! >> Applied to the hisilicon dt tree since the driver part is in the mainlin= e now. >> > > Is this refering to https://github.com/hisilicon/linux-hisi/commits/next/= dt64 ? > > [...] > > -- > Cl=C3=A9ment B. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html