From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <20171103195855.15283-1-geomatsi@gmail.com> <20171103195855.15283-2-geomatsi@gmail.com> From: Sergey Matyukevich Date: Sat, 4 Nov 2017 18:39:23 +0300 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect Content-Type: multipart/alternative; boundary="001a114446cc9627a2055d2a06d6" To: Jagan Teki Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Rutland , devicetree , linux-arm-kernel List-ID: --001a114446cc9627a2055d2a06d6 Content-Type: text/plain; charset="UTF-8" > Hi, > > > The sdcard detect pin on orange-pi-zero-plus2 is pulled up. > > Fix cd-gpio description to enable sdcard detect. > > > > Signed-off-by: Sergey Matyukevich > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > > index b6b7a561df8c..a42fd79a62a3 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > > @@ -71,7 +71,7 @@ > > pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>; > > vmmc-supply = <®_vcc3v3>; > > bus-width = <4>; > > - cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; > > + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; > > Was able to detect and do mount with existing dts Did you try to boot from sdcard ? I am not able to boot my board from sd-card without this change. As I mentioned earlier in my email to buildroot mailing list, with mmc debug enabled I see that mmc tries to init sd-card when I remove it from the slot. Maybe there is a minor differences between h/w versions or batches ? What is you board version ? My board is v1.0. Regards, Sergey --001a114446cc9627a2055d2a06d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi,
=C2=A0
> The sdcard detect pin on orange-pi-zero-plus2 is pulled up.
> Fix cd-gpio description to enable sdcard detect.
>
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---
>=C2=A0 arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2= .dts | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> index b6b7a561df8c..a42fd79a62a3 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-= plus2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-= plus2.dts
> @@ -71,7 +71,7 @@
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pinctrl-0 =3D <&mmc0_pins_a>= ;, <&mmc0_cd_pin>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vmmc-supply =3D <&reg_vcc3v3&g= t;;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bus-width =3D <4>;
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_= HIGH>;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_= LOW>;

Was able to detect and do mount with existing dts
<= br>
Did you try to boot from sdcard ? I am not able to boot my bo= ard from sd-card without this change.
As I mentioned earlier in m= y email to buildroot mailing list, with mmc debug enabled I see that mmc
tries to init sd-card when I remove it from the slot.
Maybe there is a minor differences between h/w versions or batc= hes ? What is you board version ?
My board is v1.0.

Regards,
Sergey
--001a114446cc9627a2055d2a06d6--