From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4962C61DA4 for ; Wed, 15 Mar 2023 16:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233039AbjCOQAn (ORCPT ); Wed, 15 Mar 2023 12:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232951AbjCOQAb (ORCPT ); Wed, 15 Mar 2023 12:00:31 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8BF47DD2D for ; Wed, 15 Mar 2023 08:59:58 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id e71so11509287ybc.0 for ; Wed, 15 Mar 2023 08:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1678895980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4Hkb0Z/tYYZSdI2YGR7CKQ+EDo9PzMXn0G/3i+Y5MwM=; b=HAvxY2y0K98/w3C339mOOAQzkXNU7suKDrE+oReOnAWfju0KoSCgolXdK+X4r8CHgN afroLwSaC3Wk3W9YQ9WmLcLtBWLq8ohidkk5GyWA1ua9r58tBWi716eqikZ6WWjMnjX6 3HpK5Y2MjFvO5Aecw1aUn4xEjsk4IEZARbMPHMmUNRYnyEhc0dERnPIcwEuIIkioSz7v qKI+pEHFV4AV5vKJV1pVlmlnx2C71iwjsEtqfre5+RK9YuC6r4JpoqlgV4jx+mwjv5MN YZZwlGAnv7UcksfYDh5vmrh1x+tyvVOnmpRCxVj0cqWkzGXgUIafjbjn2mn/k7pBylNJ wBpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678895980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Hkb0Z/tYYZSdI2YGR7CKQ+EDo9PzMXn0G/3i+Y5MwM=; b=mg/svZsc88CIzq+cJmZP6RWZ6UrgUnv4jZmrcBeRMH4ww7ELqxkR650vw5SgtlwWRL 864WrEr+E4tExAWvG/0Uvb+ZD+aVxMrdR9EJOVZlUlk/h+gdEjMGl0qmm5zr9Lz0M6Cr xldkyo1Zws6DcOqsqQIaCGpuLJVKbo2WuLOH9oobZfurw2oIMfuo0Z6axhhWn4NguAdl TTmD3/4+qvN8Hj0tCWml1BYNzrwFIi+y0V02WbEurHzwJMOaxc5blu9diXwZpEv5gLCa PsB6wnjO3m/xKcTpIKeLblIu1aNLPwPf6FQ6GFEa2UIeSwuCLUpJXkRbqOffYrtFqkEZ bgeA== X-Gm-Message-State: AO0yUKUqncrCHusnxD/lt1GoCPeY9yipGV+YSsxNUOEgYWfpBnIVHVK9 98uWuVEynK/arFGcWz9jx9Dj4JjPMKbjHalFnCWAgg== X-Google-Smtp-Source: AK7set+cRmZtlbO9MMeDKr/hukXl0wpMQ3FA/Xz+syeKJfKfZEuF5mOSKngD+5GIMx1/X8Swm2YFxI5NP785yU6JIh0= X-Received: by 2002:a5b:386:0:b0:b0a:7108:71e9 with SMTP id k6-20020a5b0386000000b00b0a710871e9mr12111573ybp.4.1678895980181; Wed, 15 Mar 2023 08:59:40 -0700 (PDT) MIME-Version: 1.0 References: <20230220-display-v1-0-45cbc68e188b@baylibre.com> <20230220-display-v1-21-45cbc68e188b@baylibre.com> <4b4d4749-c5ea-3a02-190e-3db703623977@linaro.org> In-Reply-To: <4b4d4749-c5ea-3a02-190e-3db703623977@linaro.org> From: Alexandre Mergnat Date: Wed, 15 Mar 2023 16:59:29 +0100 Message-ID: Subject: Re: [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display To: neil.armstrong@linaro.org Cc: Daniel Vetter , CK Hu , Jitao Shi , Thierry Reding , Philipp Zabel , Sam Ravnborg , Rob Herring , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Chun-Kuang Hu , Matthias Brugger , David Airlie , Krzysztof Kozlowski , Xinlei Lee , Guillaume La Roque , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Fabien Parent , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Neil, Le jeu. 9 mars 2023 =C3=A0 15:51, Neil Armstrong a =C3=A9crit : > > + > > +#include > > Is this include needed ? Seems not, I remove it. > > + struct gpio_desc *enable_gpio; > > + struct gpio_desc *reset_gpio; > > + struct gpio_desc *dcdc_en_gpio; > > Isn't this "DCDC" a regulator ??? According to the panel datasheet, this is an input signal needed passing through TFT connector (PIN30): "Power IC supply enable, High active" > > + /* Interface setting, video mode */ > > + ret =3D mipi_dsi_generic_write(dsi, > > + (u8[]){DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00},= 6); > > + if (ret < 0) { > > + dev_err(dev, "failed to set display interface setting: %d= \n", > > + ret); > > + return ret; > > + } > > Use mipi_dsi_generic_write_seq(dsi, DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0= x00); instead, > it's simpler and doesn't need explicit return check. "mipi_dsi_generic_write_seq" doesn't exist but I will add it below "mipi_dsi_dcs_write_seq" in drm_mipi_dsi.h I must keep the return check to jump out of "stk_panel_init" if something goes wrong, but I can drop the error print. > > +static int stk_panel_enable(struct drm_panel *panel) > > +{ > > + struct stk_panel *stk =3D to_stk_panel(panel); > > + > > + if (stk->enabled) > > + return 0; > > + > > + backlight_enable(stk->backlight); > > + > > + stk->enabled =3D true; > > + > > + return 0; > > +} > > Is this really needed ? the backlight core will enable it automatically. Ok, it's managed by drm_panel.c driver. Then I can also remove stuff from stk_panel_disable. Regards, Alex