From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harini Katakam Subject: Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Date: Mon, 5 Dec 2016 08:25:11 +0530 Message-ID: References: <1480326567-6132-1-git-send-email-harinik@xilinx.com> <20161203213553.f3agwvaseufglnq6@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20161203213553.f3agwvaseufglnq6@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Harini Katakam , Nicolas Ferre , David Miller , Pawel Moll , Mark Rutland , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Kumar Gala , Boris Brezillon , alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "michals-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Rob, Thanks for the review. On Sun, Dec 4, 2016 at 3:05 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: >> +Required properties: >> +- compatible: Should be "cdns,macb-mdio" > > Only one version ever? This needs more specific compatible strings. > This is part of the Cadence MAC in a way. I can use revision number from the Cadence spec I was working with. But it is not necessarily specific that version. I'll take care of the other comments in the next version. Regards, Harini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html