From: Vivek Gautam <gautamvivek1987@gmail.com>
To: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org
Cc: Vivek Gautam <gautam.vivek@samsung.com>,
kgene.kim@samsung.com, thomas.abraham@linaro.org,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH 2/2] ARM: Exynos5250: Enabling ohci-exynos driver
Date: Wed, 31 Oct 2012 12:25:54 +0530 [thread overview]
Message-ID: <CAFp+6iG8M2UaPTZS2dbWq2pyRmnn0bkuFuLWcQGL=rQ7a9UYog@mail.gmail.com> (raw)
In-Reply-To: <003901cda5f8$2a4f3980$7eedac80$%han@samsung.com>
Hi all,
On Tue, Oct 9, 2012 at 1:59 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Friday, October 05, 2012 7:10 PM Vivek Gautam wrote
>>
>> Adding OHCI device tree node for Exynos5250 along with
>> the device base address.
>>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>
> It looks good. Also I have tested this patch with Exynos5250.
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
Any thought about this please.
>> ---
>> .../devicetree/bindings/usb/exynos-usb.txt | 15 +++++++++++++++
>> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
>> arch/arm/mach-exynos/include/mach/map.h | 1 +
>> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
>> 4 files changed, 24 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt
>> b/Documentation/devicetree/bindings/usb/exynos-usb.txt
>> index 56e35c7..bff10a8 100644
>> --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
>> @@ -23,3 +23,18 @@ Example:
>> interrupts = <0 71 0>;
>> samsung,vbus-gpio = <&gpx2 6 1 3 3>;
>> };
>> +
>> +OHCI
>> +Required properties:
>> + - compatible: should be "samsung,exynos-ohci" for USB 2.0
>> + OHCI companion controller in host mode.
>> + - reg: physical base address of the controller and length of memory mapped
>> + region.
>> + - interrupts: interrupt number to the cpu.
>> +
>> +Example:
>> + ohci {
>> + compatible = "samsung,exynos-ohci";
>> + reg = <0x12120000 0x100>;
>> + interrupts = <0 71 0>;
>> + };
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 73ea844..bcdfbe2 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -224,6 +224,12 @@
>> interrupts = <0 71 0>;
>> };
>>
>> + ohci {
>> + compatible = "samsung,exynos-ohci";
>> + reg = <0x12120000 0x100>;
>> + interrupts = <0 71 0>;
>> + };
>> +
>> amba {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
>> index 825fe40..cfede1f 100644
>> --- a/arch/arm/mach-exynos/include/mach/map.h
>> +++ b/arch/arm/mach-exynos/include/mach/map.h
>> @@ -196,6 +196,7 @@
>> #define EXYNOS4_PA_OHCI 0x12590000
>> #define EXYNOS4_PA_HSPHY 0x125B0000
>> #define EXYNOS5_PA_EHCI 0x12110000
>> +#define EXYNOS5_PA_OHCI 0x12120000
>> #define EXYNOS4_PA_MFC 0x13400000
>>
>> #define EXYNOS4_PA_UART 0x13800000
>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
>> index 6d950d7b..e6c2144 100644
>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
>> @@ -74,6 +74,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
>> "exynos-gsc.3", NULL),
>> OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
>> "s5p-ehci", NULL),
>> + OF_DEV_AUXDATA("samsung,exynos-ohci", EXYNOS5_PA_OHCI,
>> + "exynos-ohci", NULL),
>> {},
>> };
>>
>> --
>> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks & Regards
Vivek
prev parent reply other threads:[~2012-10-31 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 10:10 [PATCH 0/2] Enable ehci and ohci devices for exynos5250 Vivek Gautam
2012-10-05 10:10 ` [PATCH 1/2] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam
2012-10-09 8:27 ` Jingoo Han
2012-10-31 6:57 ` Vivek Gautam
2012-10-05 10:10 ` [PATCH 2/2] ARM: Exynos5250: Enabling ohci-exynos driver Vivek Gautam
2012-10-09 8:29 ` Jingoo Han
2012-10-31 6:55 ` Vivek Gautam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFp+6iG8M2UaPTZS2dbWq2pyRmnn0bkuFuLWcQGL=rQ7a9UYog@mail.gmail.com' \
--to=gautamvivek1987@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gautam.vivek@samsung.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).