From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FCFC433FE for ; Mon, 27 Sep 2021 22:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47075610FC for ; Mon, 27 Sep 2021 22:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237934AbhI0WvR (ORCPT ); Mon, 27 Sep 2021 18:51:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238012AbhI0WvR (ORCPT ); Mon, 27 Sep 2021 18:51:17 -0400 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A402EC061765 for ; Mon, 27 Sep 2021 15:49:38 -0700 (PDT) Received: by mail-ua1-x936.google.com with SMTP id 2so13178488uav.1 for ; Mon, 27 Sep 2021 15:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l3Govj1Ggv6fnK3dXfFXh4R4w4mAAKZUo/5Lt6qGfhI=; b=Iq5vAXCv2EMz7F+Lo3dTfVrteNUNq7v81PHVhbhOsX5XpUjjgXfRLR72Oozo+4Rd28 avv9yUHE6tuOtdTZvzc9WXaYi+m9yRhkz0esk2t4hBvj2j9/iNMEYnDKiLQv27KlzGnU KNtCEtConX/KW5Z8fpL4XbTssq9e8C35PemeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l3Govj1Ggv6fnK3dXfFXh4R4w4mAAKZUo/5Lt6qGfhI=; b=pM47UM5eixqMZ1/v5BGY23E5g44DmckukM6nppGCwbE/vmXD13EJTe3q7FILlmww0D r6V5XFIth704YQpCNJhywzWBLLQZgSgX8uGJ3LeP6qKVHKCHXDVAXPFu85z1+cvuWKPM cOlaMcupbe+1bZng5yR5eUbN6++dZsoxiat2Fdd1vBwvSPT2txlxPSnVWBkYOS4mrFdc 6BuX+xAad7JFGjORrfPh1q51aR9ZhNS+lqaXEnd2kNv/bChq97tV3kOoTcBkIBV2nKEL Il7n7NP6YTMqhvIIGgDT/s2SOKP57VviT/1LTC2Xt+UR0W22zmlO/uDspt3aSwfaD34z D5mw== X-Gm-Message-State: AOAM5312YdktWeshEH5VuS/kXEHebEjrFd91hYK6Tw/6eVJIzPipt86k 4rWrJBj5mVqtXN48TxNi6RNC21d1wBYBnTxiU0eniw== X-Google-Smtp-Source: ABdhPJw93xHWEfPQbedVUspaJQ+Kpz4lDjxMsiLCz9VQF0pLxWLXngzwY9I3WjVpCLk0lSx8d9/HMX6++hBMj4ge2eY= X-Received: by 2002:ab0:8c1:: with SMTP id o1mr2454160uaf.113.1632782977502; Mon, 27 Sep 2021 15:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20210923065500.2284347-1-daniel@0x0f.com> <20210923065500.2284347-4-daniel@0x0f.com> In-Reply-To: From: Daniel Palmer Date: Tue, 28 Sep 2021 07:51:40 +0900 Message-ID: Subject: Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger To: Rob Herring Cc: DTML , "open list:GPIO SUBSYSTEM" , linux-leds@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , pavel@ucw.cz, linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Tue, 28 Sept 2021 at 04:52, Rob Herring wrote: > > On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote: > > The "activity" trigger can be used as the default but it's currently > > undocumented so validating a devicetree that uses it causes a warning. > > It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some > reason that can't be used? LED_FUNCTION_CPU seems to be tied to drivers/leds/trigger/ledtrig-cpu.c which I think serves the same purpose but does it a slightly different way. Would adding LED_FUNCTION_ACTIVITY work? Thanks, Daniel