From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFABCA9EAF for ; Mon, 28 Oct 2019 02:32:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7688F20650 for ; Mon, 28 Oct 2019 02:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IysszB7/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729334AbfJ1Ccy (ORCPT ); Sun, 27 Oct 2019 22:32:54 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35537 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbfJ1Ccx (ORCPT ); Sun, 27 Oct 2019 22:32:53 -0400 Received: by mail-wr1-f66.google.com with SMTP id l10so8214278wrb.2 for ; Sun, 27 Oct 2019 19:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w7WLAChacz4cdQUuGvSzDH2SDjigryRCbt+WDbtW90s=; b=IysszB7/4YwlqN2hIxbjmBzRqB+jb5hB3Tg+ljjzuq3A+FEhC3OFZFMovTbRT0LJfK H4qNyEspy1rpsUjibdaW/gAWpBeFZqCkQNS/a6m2giKGzWFHNCZXv+UikEp3b05qqUYQ XL2aGPYxYupmlhSDoZ4ce3ZDLKnBEnisKO4aE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w7WLAChacz4cdQUuGvSzDH2SDjigryRCbt+WDbtW90s=; b=EtQOT+ayKzPTOX2mHYNoBKsEKx+VbM+st12pi1GpKbQpPcJpOiIFfwuriE5wiuORI2 uaS7FDzRh+Oc6uon3TkJO9LMKLTYdDdeS5HUG2bkB7O0nnZhAKWUqsc178PRR4COR/AD cI5zwVr6b/3KkGJ1yfoST8JB2RX7O6k/QX7sCdRG/kV4gK6BSBFIvhqI5ZDNV/Tgd8Rj I1lnFVF0njWAqKew1jZrlr4UcguEleWSaindh2TglPW+EjF6X5sCZ2GK9sbEgxvSYXzd E6xGgbv5/+mwBtGttaqI7uapcG1wkMQg+pLU7+fuPcROEesZEeOnjs5pZJtgQB6Gk2sw 1Rfg== X-Gm-Message-State: APjAAAWCgEiB/ILdKbvLb1bjhoUG/gDmAq2BQzzqkcOEJhwiXIf0WlFN f1luEHbKq46QovEZBzLVQkR2QYhbNaen/Vfod/c3yA== X-Google-Smtp-Source: APXvYqzK0YBdyQgsMLm2ci9Dx4kOzJFycGTSzYpVPVfKV8gCZkiX6U1k76C9C14EYAVMDUxQGFHxdvyM+PTOBO8Lys4= X-Received: by 2002:adf:b1d1:: with SMTP id r17mr12904765wra.201.1572229970951; Sun, 27 Oct 2019 19:32:50 -0700 (PDT) MIME-Version: 1.0 References: <20191025133007.11190-1-cychiang@chromium.org> <20191025133007.11190-3-cychiang@chromium.org> <20191025162232.GA23022@bogus> In-Reply-To: <20191025162232.GA23022@bogus> From: Cheng-yi Chiang Date: Mon, 28 Oct 2019 10:32:24 +0800 Message-ID: Subject: Re: [PATCH v8 2/6] ASoC: rockchip-max98090: Support usage with and without HDMI To: Rob Herring Cc: linux-kernel , Neil Armstrong , Jerome Brunet , Jernej Skrabec , Jonas Karlman , Hans Verkuil , Mark Brown , Liam Girdwood , Takashi Iwai , Jaroslav Kysela , Russell King , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Heiko Stuebner , Mark Rutland , Doug Anderson , Dylan Reid , Tzung-Bi Shih , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Oct 26, 2019 at 12:22 AM Rob Herring wrote: > > On Fri, Oct 25, 2019 at 09:30:03PM +0800, Cheng-Yi Chiang wrote: > > There will be multiple boards sharing this machine driver. > > Use compatible string to specify the use case. > > > > "rockchip,rockchip-audio-max98090" for max98090-only. > > "rockchip,rockchip-audio-hdmi" for HDMI-only > > "rockchip,rockchip-audio-max98090-hdmi" for max98090 plus > > > > Move these properties to optional because they are not needed for > > HDMI-only use case. > > "rockchip,audio-codec": The phandle of the MAX98090 audio codec > > "rockchip,headset-codec": The phandle of Ext chip for jack detection > > > > The machine driver change will add support for HDMI codec in > > rockchip-max98090. > > Add one optional property "rockchip,hdmi-codec" to let user specify HDMI > > device node in DTS so machine driver can find hdmi-codec device node for > > codec DAI. > > Why not just use the presence of rockchip,hdmi-codec to enable HDMI or > not. Maybe you still add rockchip,rockchip-audio-hdmi for HDMI only. > > Really, the same should have been done for which codec is used too, but > I guess someone wanted 2 machine drivers. Hi Rob, Thanks for the quick reply. I can make change in machine driver so that - The presence of rockchip,audio-codec enable max98090 - The presence of rockchip,hdmi-codec enable HDMI. With that, we don't need the three properties added in this patch: "rockchip,rockchip-audio-max98090" for max98090-only. "rockchip,rockchip-audio-hdmi" for HDMI-only "rockchip,rockchip-audio-max98090-hdmi" for max98090 plus HDMI. I will post an update soon. Thanks! > > > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/sound/rockchip-max98090.txt | 38 +++++++++++++++++-- > > 1 file changed, 35 insertions(+), 3 deletions(-)