From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 307CA174ED2 for ; Fri, 21 Jun 2024 12:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718971697; cv=none; b=AzYypxfzPwSzkhtP7GUvMFftmyLuF4TmeW/bxeiHc35MDHBCgIvUItVA9Jd+UaBJBNlxOz8eWK7cn4bQRYptVKfTpyQuMI2ldd4zX2zwcwDp8Ar5NpnzKts97M0X9wvk9v2fzgocRWOMnmDViy+jWlf5V7GqsSrkLdv+hsUlvIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718971697; c=relaxed/simple; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=QSm61UehE6/0phloIX5YeyhJc4pflZzwnx9OzGex5BM4/JMI4YDvXtysyHPtX2yTBgmUYSC3721B+IVmKvv0xUz38zPe34bCSrwolVy1FinugG34hPcv1+tMTliQAjta2/ksJJkOXDvige6G1tYx8ZIVNWaq2+hB/2YkMN+sigY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=timesys.com; spf=pass smtp.mailfrom=timesys.com; dkim=pass (2048-bit key) header.d=timesys-com.20230601.gappssmtp.com header.i=@timesys-com.20230601.gappssmtp.com header.b=bwNl9B2b; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=timesys.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=timesys.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=timesys-com.20230601.gappssmtp.com header.i=@timesys-com.20230601.gappssmtp.com header.b="bwNl9B2b" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7960454db4fso123516785a.2 for ; Fri, 21 Jun 2024 05:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20230601.gappssmtp.com; s=20230601; t=1718971694; x=1719576494; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=bwNl9B2b5uBkts+d4e1DdRjRmxBlNK3fTwlrYckofd8DFZRyHpP+wuYJNoiJFzIY0N 6J2XMZlIWqrBJdPaUYzL7AaytwBd2cv+HOibYo5pDM/cXmrBDsHNLJJg2+DNxDbfTG01 PGNcSY0E5srlf0xby1j0hw0vKWRgAxMKkG1uK9hQshCVklS2nrHA+8JMmi+OcLH9ExEM 76uZVM00QNMp5apgZUS8HFiWsw1t/COUYq6QZDqgb2TK+SDiYiCU5xgaajdsU4GHyF4a TgfV1+fSkkp2MooWuTU1LdWf577gqcZAi+/zsQBwMkDc00qjp1XBC1jfhw4NHZJs/Mg0 fn5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718971694; x=1719576494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=OKG4b08EDlGXKxHNGORlUU4QCOTnu4BmSB1R/4fcYooMhO1c3Toj2UbQN7b2wPH0fV AXJOImNNTvAi7om0YDlzrgGbCa3sOy5oG/ERW07KiYciH6/oZOBtOYVdHWl0xVYSsxJW rHiV2qIQiAwXfA3SXrl0Y/NUzKgwkF7jv9POcfS1XtEuY8TfQvdjSpKkJvjr/LnxvP7t qqj9xFCfMnOaII6SqU7pdyiHB3m8bWP5ft4SnjdwmapkNzoS6migZhNOcWkZVG3gaEJ9 wRkCHbczKvYAcF8OWSrezax9CJd+2ak14Vvs77ShaJQqdXy74hIk5i+v2vunSNNLvbe2 5V7A== X-Forwarded-Encrypted: i=1; AJvYcCWUZrs90332x/N20ESWSq6EnI3hQQLbX+3+hLmrWvliKXP9oXB4LHs551G+rl/aY5cDXcRdDVb8ZX67+3p++nyDcDHbYCuAGTFhnQ== X-Gm-Message-State: AOJu0YzbiLmIJbfijJ0tzc35gC94JBK0s7PJiuBxQq6QH0wmU7rEToIF AEnQCdVn7JZYcM/CHXUDrpSJJytnzZmH3nL1n+LN96mG3vUniIyRTeRE0vJ7Zlzbxr4fXrgndA5 nOm8hjAWEQktubT6vRBV/uQq0jpEdFwGzDj353w== X-Google-Smtp-Source: AGHT+IH9SeiO8vfdoOxDABbDkc1VlJaHvluIQfS8YUVwP2eXorBPvqf3BAKJdJfTNAn0CNJ3/z1faNaXrP6fson02ac= X-Received: by 2002:ad4:4245:0:b0:6b0:6629:bdf9 with SMTP id 6a1803df08f44-6b501e2c710mr72849356d6.21.1718971694039; Fri, 21 Jun 2024 05:08:14 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240620175657.358273-1-piotr.wojtaszczyk@timesys.com> <20240620175657.358273-11-piotr.wojtaszczyk@timesys.com> In-Reply-To: From: Piotr Wojtaszczyk Date: Fri, 21 Jun 2024 14:08:03 +0200 Message-ID: Subject: Re: [Patch v4 10/10] i2x: pnx: Use threaded irq to fix warning from del_timer_sync() To: Andi Shyti Cc: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "J.M.B. Downing" , Vladimir Zapolskiy , Liam Girdwood , Mark Brown , Russell King , Michael Turquette , Stephen Boyd , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , Yangtao Li , Li Zetao , Chancel Liu , Michael Ellerman , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, Markus Elfring Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andi, On Fri, Jun 21, 2024 at 12:57=E2=80=AFAM Andi Shyti = wrote: > On Thu, Jun 20, 2024 at 07:56:41PM GMT, Piotr Wojtaszczyk wrote: > > When del_timer_sync() is called in an interrupt context it throws a war= ning > > because of potential deadlock. Threaded irq handler fixes the potential > > problem. > > > > Signed-off-by: Piotr Wojtaszczyk > > did you run into a lockdep splat? > > Anything against using del_timer(), instead? Have you tried? I didn't get a lockdep splat but console was flooded with warnings from https://github.com/torvalds/linux/blob/v6.10-rc4/kernel/time/timer.c#L1655 In the linux kernel v5.15 I didn't see these warnings. I'm not a maintainer of the driver and I didn't do any research on what kind of impact would have using del_timer() instad. Maybe Vladimir Zapolskiy will know tha= t. --=20 Piotr Wojtaszczyk Timesys