From: Gabriel Fernandez <gabriel.fernandez@linaro.org>
To: Rob Herring <robh@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
Patrice Chotard <patrice.chotard@st.com>,
Russell King <linux@armlinux.org.uk>,
Olivier Bideau <olivier.bideau@st.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Pankaj Dev <pankaj.dev@st.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Arnd Bergmann <arnd@arndb.de>,
Thierry Reding <treding@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@stlinux.com" <kernel@stlinux.com>linux-clk <l>
Subject: Re: [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms
Date: Mon, 20 Jun 2016 09:29:18 +0200 [thread overview]
Message-ID: <CAG374jD+qChVC+6QJEHSXSzXGVVtAxvZ3V6zNpQDUyuJ2yCjMw@mail.gmail.com> (raw)
In-Reply-To: <20160619150458.GA26824@rob-hp-laptop>
Hi Rob,
On 19 June 2016 at 17:04, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 16, 2016 at 11:20:22AM +0200, Gabriel Fernandez wrote:
>> This patch reworks the clock binding to avoid too much detail in DT.
>> Now we have only compatible string per type of clock
>> (remark from Rob https://lkml.org/lkml/2016/5/25/492)
>>
>
> I have no idea what the clock trees and clock controller in these chips
> look like, so it's hard to say if the changes here are good. It still
> looks like things are somewhat fine grained clocks in DT. I'll leave
> it up to the platform maintainers to decide...
>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
>> ---
>> .../devicetree/bindings/clock/st/st,clkgen-mux.txt | 2 +-
>> .../devicetree/bindings/clock/st/st,clkgen-pll.txt | 11 ++--
>> .../devicetree/bindings/clock/st/st,clkgen.txt | 2 +-
>> .../devicetree/bindings/clock/st/st,quadfs.txt | 6 +--
>> drivers/clk/st/clkgen-fsyn.c | 41 ++++++--------
>> drivers/clk/st/clkgen-mux.c | 28 ++++------
>> drivers/clk/st/clkgen-pll.c | 62 ++++++++++------------
>> 7 files changed, 65 insertions(+), 87 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt b/Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt
>> index 4d277d6..9a46cb1d7 100644
>> --- a/Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt
>> +++ b/Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt
>> @@ -10,7 +10,7 @@ This binding uses the common clock binding[1].
>> Required properties:
>>
>> - compatible : shall be:
>> - "st,stih407-clkgen-a9-mux", "st,clkgen-mux"
>> + "st,stih407-clkgen-a9-mux"
>>
>> - #clock-cells : from common clock binding; shall be set to 0.
>>
>> diff --git a/Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt b/Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt
>> index c9fd674..be0b043 100644
>> --- a/Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt
>> +++ b/Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt
>> @@ -9,11 +9,10 @@ Base address is located to the parent node. See clock binding[2]
>> Required properties:
>>
>> - compatible : shall be:
>> - "st,stih407-plls-c32-a0", "st,clkgen-plls-c32"
>> - "st,stih407-plls-c32-a9", "st,clkgen-plls-c32"
>> - "sst,plls-c32-cx_0", "st,clkgen-plls-c32"
>> - "sst,plls-c32-cx_1", "st,clkgen-plls-c32"
>> - "st,stih418-plls-c28-a9", "st,clkgen-plls-c32"
>
>> + "st,clkgen-pll0"
>> + "st,clkgen-pll0"
>
> Repeated. Supposed to be 0 and 1? This seems a bit generic, too.
Yes you are right, it's 0 and 1.
I wait remarks from Mike or Stephen before send a V3.
Thanks Rob
BR
Gabriel
>
>> + "st,stih407-clkgen-plla9"
>> + "st,stih418-clkgen-plla9"
next prev parent reply other threads:[~2016-06-20 7:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 9:20 [RESEND PATCH v2 00/13] Clock improvement for video playback Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 01/13] drivers: clk: st: Remove stih415-416 clock support Gabriel Fernandez
2016-06-19 14:57 ` Rob Herring
2016-06-16 9:20 ` [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms Gabriel Fernandez
2016-06-19 15:04 ` Rob Herring
2016-06-20 7:29 ` Gabriel Fernandez [this message]
2016-07-08 1:43 ` Michael Turquette
2016-07-08 9:12 ` Gabriel Fernandez
2016-07-08 16:08 ` Michael Turquette
2016-07-11 6:58 ` Gabriel Fernandez
2016-08-22 16:06 ` Gabriel Fernandez
2016-08-25 0:11 ` Michael Turquette
2016-08-25 14:51 ` Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 03/13] drivers: clk: st: Add fs660c32 synthesizer algorithm Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 04/13] drivers: clk: st: Add clock propagation for audio clocks Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 05/13] drivers: clk: st: Handle clk synchronous mode for video clocks Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 06/13] ARM: DT: STiH407: Enable clock propagation for audio clocks Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 07/13] ARM: DT: STiH410: " Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 08/13] ARM: DT: STiH418: " Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 09/13] ARM: DT: STiH407: Enable synchronous clock mode for video clocks Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 10/13] ARM: DT: STiH410: " Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 11/13] ARM: DT: STiH418: " Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 12/13] ARM: DT: STi: STiH407: clock configuration to address 720p and 1080p Gabriel Fernandez
2016-06-16 9:20 ` [RESEND PATCH v2 13/13] ARM: DT: STi: STiH410: " Gabriel Fernandez
2016-08-05 8:11 ` [RESEND PATCH v2 00/13] Clock improvement for video playback Patrice Chotard
2016-08-25 11:44 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG374jD+qChVC+6QJEHSXSzXGVVtAxvZ3V6zNpQDUyuJ2yCjMw@mail.gmail.com \
--to=gabriel.fernandez@linaro.org \
--cc=a.hajda@samsung.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.coquelin@st.com \
--cc=mturquette@baylibre.com \
--cc=olivier.bideau@st.com \
--cc=pankaj.dev@st.com \
--cc=patrice.chotard@st.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).