From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861F9C433F5 for ; Thu, 26 May 2022 12:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347335AbiEZMlL (ORCPT ); Thu, 26 May 2022 08:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347200AbiEZMlD (ORCPT ); Thu, 26 May 2022 08:41:03 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38DEF9D055 for ; Thu, 26 May 2022 05:41:00 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id qe5-20020a17090b4f8500b001e26126abccso409039pjb.0 for ; Thu, 26 May 2022 05:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1Rj1FYBiOvZLhBZCkRxGB9isSInLDH4Eii5EQ0dZppM=; b=YZPVPzqOw96zZveL7AOUNsY1sG+cTXdDluJDV13rwdILIi9W5IIMMZQ4JEwh8Upqj6 4MmHtKVZkYVuvTh/lAd+eybNMJnwgkn0zhvH+AV72IXN5agIMH/Gr46BxY34z4+LwPFU FMan1xtIpwAzS13DruwpmZn/JHzF4dEijaYzr1i0zVXYAoVXbLUrl5N1dmkUXvkqo5Bo zZNYfUIt8qoG3rh7HsSOZ87nIhABitYpatTFipEqtTljc5LWIhE6Um31wB2w/ElPeNVE WBxTP02t8a+JQEJ0fYxsIrVylMGX6AC3/RjaE0+0QFqIoIbJSB2G2ttgIUmGXplaNE5B 74dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1Rj1FYBiOvZLhBZCkRxGB9isSInLDH4Eii5EQ0dZppM=; b=BgQ+y7J/y4KSwjh6lm2wSkM+OT2lZGoHCPE3N1d+8uBiOZaJs8vxfmE+yi3JHc0eFe tk/9tOjcgxrfffw0s+faDB0LIIzF9Kn+IyeXSMcep/3e1WH0MlmAM2tYRqcLpQsv2VIp rsI8xI+X/SEE/0a2RJb/UWbnFk4yCMN3ggEGGK8N2diH/nQ8kgU1ywfRxgN9tM9pCmhe +9g04LDpB+O0HJytkIeumzBbVqIPueVi6IV9ilEeAslGSySAWXNWgSaueIwB251LAzdI Hla4qf4VfuHPIppfA0z4b0yM5NZ642ZqWD3fUPUvzj2J6K8b40z+fvJqBGewFuaOBhJZ 4z/w== X-Gm-Message-State: AOAM5305khtdB5zklGPsOt8asN096n6s41cMDNSax/kD8V9qzYIAU0GC NOgxbm5TVkg5EV2k0S1DKe6+jJvY1c49P6iS+G3vkQ== X-Google-Smtp-Source: ABdhPJyGQgT/BgWH1jsAbLqPk5ImtjgKyHKNaAQiFZB75mBBs8krUR0vq3nyaEkmEgd+MbH8+MRQdqS81o5QPOt+zNY= X-Received: by 2002:a17:90b:380f:b0:1e0:aa6:9e24 with SMTP id mq15-20020a17090b380f00b001e00aa69e24mr2459758pjb.232.1653568859590; Thu, 26 May 2022 05:40:59 -0700 (PDT) MIME-Version: 1.0 References: <20220522162802.208275-1-luca@z3ntu.xyz> <20220522162802.208275-8-luca@z3ntu.xyz> In-Reply-To: <20220522162802.208275-8-luca@z3ntu.xyz> From: Robert Foss Date: Thu, 26 May 2022 14:40:48 +0200 Message-ID: Subject: Re: [RFC PATCH 07/14] media: camss: csiphy: Add support for 8x74 To: Luca Weiss Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Loic Poulain , Rob Herring , Krzysztof Kozlowski , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, matti.lehtimaki@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 22 May 2022 at 18:28, Luca Weiss wrote: > > From: Matti Lehtim=C3=A4ki > > CSIPHY hardware modules in 8x74 and 8x16 are similar. > > Signed-off-by: Matti Lehtim=C3=A4ki > Signed-off-by: Luca Weiss > --- > drivers/media/platform/qcom/camss/camss-csiphy.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/m= edia/platform/qcom/camss/camss-csiphy.c > index 75fcfc627400..a0122705a874 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c > @@ -557,7 +557,8 @@ int msm_csiphy_subdev_init(struct camss *camss, > csiphy->id =3D id; > csiphy->cfg.combo_mode =3D 0; > > - if (camss->version =3D=3D CAMSS_8x16) { > + if (camss->version =3D=3D CAMSS_8x16 || > + camss->version =3D=3D CAMSS_8x74) { CHECK: Alignment should match open parenthesis #27: FILE: drivers/media/platform/qcom/camss/camss-csiphy.c:561: + if (camss->version =3D=3D CAMSS_8x16 || + camss->version =3D=3D CAMSS_8x74) { > csiphy->ops =3D &csiphy_ops_2ph_1_0; > csiphy->formats =3D csiphy_formats_8x16; > csiphy->nformats =3D ARRAY_SIZE(csiphy_formats_8x16); > @@ -582,6 +583,7 @@ int msm_csiphy_subdev_init(struct camss *camss, > return PTR_ERR(csiphy->base); > > if (camss->version =3D=3D CAMSS_8x16 || > + camss->version =3D=3D CAMSS_8x74 || > camss->version =3D=3D CAMSS_8x96) { > csiphy->base_clk_mux =3D > devm_platform_ioremap_resource_byname(pdev, res->= reg[1]); > -- > 2.36.0 > With that fixed: Reviewed-by: Robert Foss