From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C008EC433F5 for ; Tue, 3 May 2022 12:03:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234558AbiECMGx (ORCPT ); Tue, 3 May 2022 08:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232033AbiECMGv (ORCPT ); Tue, 3 May 2022 08:06:51 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDFCD3134B for ; Tue, 3 May 2022 05:03:18 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id n18so14761779plg.5 for ; Tue, 03 May 2022 05:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FAu8c+I73fg5KenFJ98NzZ9OicDW8bebn+wllxjCG1E=; b=upghBDfCvCfS7iYO8pSvu7t8unu4twKivp1ctTkclyq+JT6/1Nn4M2ScumgWd2bGdi meBP8abuc0ekEDKvWtCsV7M8MtKQxcJuEy9ZroKBJTLuxP97Yr9aMNhPMJmGWHJXm/vT clShmVmUxaQvNlWovgxcqQe0PszQRNjMSMCaQ0jrG9ea/Trcs2u/WJiyzzStZ1TusfrH uiq0qpE0y4UCT7HXCSd+MCQEx5+TSjrRV0ioiScjB51ePh5PQwx6jXb5kLa+cJC8QVZ2 fg5icgWxI4ZjA7AjriR/0zKllleaiP93L517b+YEaGJj9FaRoLONytk4XMK7nW7IcEfu Ptkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FAu8c+I73fg5KenFJ98NzZ9OicDW8bebn+wllxjCG1E=; b=4zKrKE+TJoJD1msV67hRPhb7qB1XQP+qZ/siwQ2NaFHLMNFSWbZVT8LK52iD/cH8JP 4GSpW/0BXcVDXPBGO/vJMHO2ciMm8dre/qe3wtVHcVfS0INTzcEqNujqwaeI5bpj6etJ tTDBD8JwL6oyJ8YzYccsAH4FG7/mguBfXzN6IJMDRiwhlwCS+jUx1QeY8wzSsjD8iK5x M600i2jYkptTWTgILUfHSnxY7aMxY8CDMDIUbuU1komXyU06X4sGgsDTZKwLAULb2PdX Ui9uW/EyRGU+27c8gB6dvqMgfS8/TA4IUbE4f0crnoTu5PLvO6LwSQKtNbtxrlapHrxk wkFA== X-Gm-Message-State: AOAM530FW4+G37pec5wwiSlal3pGSg6Mqqq9ZH5QML1sNUT+vT6eHlm3 vr9Ds7Jh99L8H6lzjwotLAkebjgLc0uAGEyZFO07kg== X-Google-Smtp-Source: ABdhPJxWhn5VZCO/TgaV9CqU4sqOiFVkFLLPiXSUlkgroHlMnIYcuwG3brGIqnFnP/BqK7l4dbv9U1Fj7YYZ/fuYEOU= X-Received: by 2002:a17:902:bb8d:b0:156:51a1:3f5a with SMTP id m13-20020a170902bb8d00b0015651a13f5amr16302454pls.65.1651579398176; Tue, 03 May 2022 05:03:18 -0700 (PDT) MIME-Version: 1.0 References: <20220426193645.244792-1-marex@denx.de> In-Reply-To: From: Robert Foss Date: Tue, 3 May 2022 14:03:07 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge To: Rob Herring Cc: Marek Vasut , dri-devel@lists.freedesktop.org, Sam Ravnborg , Laurent Pinchart , Lucas Stach , Maxime Ripard , Peng Fan , Robby Cai , Thomas Zimmermann , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 3 May 2022 at 02:31, Rob Herring wrote: > > On Tue, Apr 26, 2022 at 09:36:44PM +0200, Marek Vasut wrote: > > The i.MX8MP contains two syscon registers which are responsible > > for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding > > which represents this serializer as a bridge. > > > > Acked-by: Sam Ravnborg > > Signed-off-by: Marek Vasut > > Cc: Laurent Pinchart > > Cc: Lucas Stach > > Cc: Maxime Ripard > > Cc: Peng Fan > > Cc: Rob Herring > > Cc: Robby Cai > > Cc: Robert Foss > > Cc: Sam Ravnborg > > Cc: Thomas Zimmermann > > Cc: devicetree@vger.kernel.org > > To: dri-devel@lists.freedesktop.org > > --- > > V2: - Consistently use fsl,imx8mp-ldb as compatible > > - Drop items: from compatible: > > - Replace minItems with maxItems in clocks: > > - Drop quotes from clock-names const: ldb > > - Rename syscon to fsl,syscon > > - Use generic name of ldb-lvds in example > > V3: - Add AB from Sam > > - Consistently use MX8MP > > V4: - Rename to fsl-ldb all over the place > > - Put the LDB node under media block controller in the example > > --- > > .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++ > > 1 file changed, 92 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > > A little quick on the applying... Darnit, you're right. Marek: Can you supply a new patch with all of the relevant changes? > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > > new file mode 100644 > > index 000000000000..77f174eee424 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > > @@ -0,0 +1,92 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale i.MX8MP DPI to LVDS bridge chip > > + > > +maintainers: > > + - Marek Vasut > > + > > +description: | > > + The i.MX8MP mediamix contains two registers which are responsible > > + for configuring the on-SoC DPI-to-LVDS serializer. This describes > > + those registers as bridge within the DT. > > This is a subblock of the mediamix? Please add 'reg' for the 2 registers > even if you use a regmap. > > I didn't find a binding for mediamix. You really need the containing > block binding before a child node. > > Rob