From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97D4C433F5 for ; Tue, 3 May 2022 16:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239503AbiECQ1T (ORCPT ); Tue, 3 May 2022 12:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237543AbiECQ1N (ORCPT ); Tue, 3 May 2022 12:27:13 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BF013D1DF for ; Tue, 3 May 2022 09:23:30 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so2717588pju.2 for ; Tue, 03 May 2022 09:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UBkRzMAF2fmEnDOx5cm8C4yWv3/2n1bAuqgP0781Seo=; b=rwEXmlzY2KoxV8/zMOBhFvw5DlF20vRth0I3M6jTU1SBvoigzfwCSX0X/3TwY2FX2g cUK1K/5FcUA7Ds5MteSf/FmNEkvAmYM0Kd9Q7c+dLfOp55GMrUpz6uvxaFzw0EdNqNyI HIhMr8cPEAJly2++bk272jmYqqVUihy7jEA1ZeKD65Nh6jnDVbolLI22uffyumPkn8Ks zm4zXgSuKOzZI5I7zxUae+wyl3GCh7sfk2jLoiLjX526hGjIY5kayZiEhiSesv40gSnp rdilNPxeJBSUaNxrRchYjHVsOocXcNuzbPUPjZvJi3qsLrsReOcmcmgq/xg+G0nr8sAv BWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UBkRzMAF2fmEnDOx5cm8C4yWv3/2n1bAuqgP0781Seo=; b=3nAgsySpW2wqR+btfITHvjQlt1QfQ211kNXrRDI9iPM17gCaMeTNqAvNMl1cd82Gwx pmlxVGSeh83Frj8J2Nccsm8T97+FMI5bIV/E5xScuZqnUfzkMvfEH24Ny7g50/RfJLC9 PfrO95Nf4957YrACwGDq/153wZJ/AqQ0hMUMwEjW0FZTfJcN7TsKtY4tnlkFcJiGzWIQ +9hMmsOhiZGcToVdkpR+8/3AbBnuk0cV/7nG8jKLzsbKUL65GoF2hqeD709oLM1UVyYx n7oHEmHnW+mS4jQQy40gv4aeisRSHvnU+3EnwaYKe8TyFJrxyKxi6GpWlmqhizDuTbiO eecw== X-Gm-Message-State: AOAM5329hW05va2qLjBRIcUT+Jd9TwN/yq9ydomSYFNcggmKEoTC2d5O Ohm38hTJHGAZzvW7kkFaSrVQw+wvLtD4gu+RojYgsA== X-Google-Smtp-Source: ABdhPJw39icUVJEDcTiertqWvLPqVUfip6kCDsWWoVMMdikQYdwVn01b80vuxcGqwl3p1a4PT4NkwLxO/a7Xy7YvTmk= X-Received: by 2002:a17:90b:1e4e:b0:1dc:583c:398 with SMTP id pi14-20020a17090b1e4e00b001dc583c0398mr5517440pjb.232.1651595009809; Tue, 03 May 2022 09:23:29 -0700 (PDT) MIME-Version: 1.0 References: <20220503130448.520470-1-robert.foss@linaro.org> In-Reply-To: From: Robert Foss Date: Tue, 3 May 2022 18:23:18 +0200 Message-ID: Subject: Re: [PATCH v2 1/8] clk: qcom: rcg2: Cache rate changes for parked RCGs To: Bjorn Andersson Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, jonathan@marek.ca, tdas@codeaurora.org, anischal@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Vinod Koul , Steev Klimaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 3 May 2022 at 17:01, Bjorn Andersson wrote: > > On Tue 03 May 08:04 CDT 2022, Robert Foss wrote: > > > From: Bjorn Andersson > > > > As GDSCs are turned on and off some associated clocks are momentarily > > enabled for house keeping purposes. Failure to enable these clocks seems > > to have been silently ignored in the past, but starting in SM8350 this > > failure will prevent the GDSC to turn on. > > > > At least on SM8350 this operation will enable the RCG per the > > configuration in CFG_REG. This means that the current model where the > > current configuration is written back to CF_REG immediately after > > parking the RCG doesn't work. > > > > Instead, keep track of the currently requested rate of the clock and > > upon enabling the clock reapply the configuration per the saved rate. > > > > Fixes: 7ef6f11887bd ("clk: qcom: Configure the RCGs to a safe source as needed") > > Signed-off-by: Bjorn Andersson > > Reviewed-by: Vinod Koul > > Tested-by: Steev Klimaszewski > > --- > > This patch has been iterated since and the latest incarnation can be > found on below link. A reference to that in the cover letter would be > sufficient. > > https://lore.kernel.org/linux-arm-msm/20220426212136.1543984-1-bjorn.andersson@linaro.org/ > Will do, thanks!