From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA26C433F5 for ; Wed, 6 Oct 2021 00:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54B3D61130 for ; Wed, 6 Oct 2021 00:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236928AbhJFAXt (ORCPT ); Tue, 5 Oct 2021 20:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbhJFAXr (ORCPT ); Tue, 5 Oct 2021 20:23:47 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3390DC061749 for ; Tue, 5 Oct 2021 17:21:56 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id g6so1514149ybb.3 for ; Tue, 05 Oct 2021 17:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nexdehnj3A/Q4zSCMfs4Cp9vmGRF+EuUGSAwg+1xmZ4=; b=S0m/IHaElRUnXHQLukKv5K2F/NOiaHimmkJHw4Y6ljjMZCsOTMz/plMk0JEzsjD3Y7 2gh5v+xfAv9Rx9E1m/QA2lQwPSJgRDlXosw6XMSwaJNybM9+/aL5w7JQ3jmxkwNVoIX+ qr7Rn+JhdLL0c35GhOwHkXfH+PeIYVkxWFw7a0jcWt9KTPfZlTdq5R5yrXhY/JY3HrML VxL6sOw5pyKzYv/rs8dX2dnGiuYEx34mP1Dy1dwaOyV58riLliZfhILaL8jq6Vp6Nrc6 wfToj27DsJDvYQg9dDRpdh21uy3fmiHWZVPdaPYxuDBLNlhIUWzzzDV1YkILGDjuzBk5 WDpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nexdehnj3A/Q4zSCMfs4Cp9vmGRF+EuUGSAwg+1xmZ4=; b=Gklwk4xNVt33z+q8gz5DjdfchvYwVvWxH11nYglzh3FkAWUq6nyd9c287Obk29VkEx 0xdF6Sn2CPYPeWcRIE5YS4qnLtFqYGIl40+PtVvKpHdMoBCv13ioBaxP1G3FtocmJLgR hPKD6VH6U6P4ts59ii+NVCi3XNAHhPAcZCmZhP0f/QuKUc0PohUhhSxXVWS6/8QNIqxJ 3IUeZFES8KgAhxxeYjsI8gPFMbmrIaag7UkmSHkUzKVuHsIckOdQCYp437vhU4lIUurQ V8RhpX67sOTXG2gadM01+rBKE6//W6feHweK8A7LzMwib7UMyUk6Z9lMalT+5au4UV6n jJdw== X-Gm-Message-State: AOAM5323auCHS8sChDVM0aWK2gixqCXsdno+rQJfUE3xYNhrHYZdS/kH Wchfd+uGXx3E4Lw++SZ6p7NNOkWC+PIQrtA3ipNQuQ== X-Google-Smtp-Source: ABdhPJyQbG+9/VI5LhOU/2D3mNx0S3Lh07wfACLKHor+iEK/YT/NP7MKSU5n4XUeiNfMOFR0CuIyDJMyrqXI2XZUX0k= X-Received: by 2002:a25:db91:: with SMTP id g139mr23977947ybf.391.1633479715227; Tue, 05 Oct 2021 17:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20210927204830.4018624-1-dmitry.baryshkov@linaro.org> <11fe1793-1455-ae44-b213-9afe47dfa370@linaro.org> <61ce03c1-1b31-bb56-8951-7b71ecdd66a9@linaro.org> In-Reply-To: <61ce03c1-1b31-bb56-8951-7b71ecdd66a9@linaro.org> From: Saravana Kannan Date: Tue, 5 Oct 2021 17:21:19 -0700 Message-ID: Subject: Re: [PATCH] Revert "of: property: fw_devlink: Add support for remote-endpoint" To: Dmitry Baryshkov Cc: Rob Herring , Frank Rowand , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 1, 2021 at 6:04 PM Dmitry Baryshkov wrote: > > On 28/09/2021 04:13, Saravana Kannan wrote: > > On Mon, Sep 27, 2021 at 5:56 PM Dmitry Baryshkov > >> After doing the analysis, I can confirm that I was too quick regarding > >> the mdss links preventing it from being probed. Sorry about that. > >> > >> It all went up to the DP phy having a link with usb-c-connector. I was > >> running the kernel 5.15-rc1, so your tcpm fix is already present. > >> However my colleague has disabled the tcpm device (which I did not > >> notice). So the driver did not call fw_devlink_purge_absent_suppliers(). > >> The devlink still exists: > > > > Let me take a closer look at this before the end of this week. Can you > > point me to the exact DT changes that were made that's causing this > > issue? It should help me debug the issue. I have a guess on what the > > issue might be. > > Here is the kernel source: > https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=5.15-rc1-camss-v2 > > The change that causes PHY driver to silently stop probing, causing an > avalanche of devices not being probed: > > https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=5.15-rc1-camss-v2&id=d0bf3fc47c132968c302965154eeb5c88007fa73 Sorry, I haven't had a chance to look into this yet, but I still have a strong hunch that this is related to how of_device_is_available() doesn't recurse up till the root to check if a node is disabled (if a parent is disabled, the child should also be considered disabled). And I think patch series should help your case due to a side effect (it wasn't meant as a fix for your issue). Can you give it a shot? https://lore.kernel.org/lkml/20210929000735.585237-1-saravanak@google.com/ -Saravana