From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D218C433F5 for ; Fri, 3 Sep 2021 17:09:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2778961058 for ; Fri, 3 Sep 2021 17:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350238AbhICRKm (ORCPT ); Fri, 3 Sep 2021 13:10:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350227AbhICRKl (ORCPT ); Fri, 3 Sep 2021 13:10:41 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0FDCC061757 for ; Fri, 3 Sep 2021 10:09:41 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id q70so11246928ybg.11 for ; Fri, 03 Sep 2021 10:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HaDVUCfDbUysF1N7KhfteSFXd3S1ciSndfL6zXNrW9s=; b=WIeC25UguFm445Yh65nz7RAmj09BG6SDqBlPdnwz/RQjRBEwX24gqVsQVr08TDpbfm NtSF2hCL7rJMYGF6oE7ghB9CEW53EGM+ITRILSCeZautrvg3vPiox2/iQE+ZKHIrQ26N W9/iz6u4V8pbk+6LcvUgb76JcUABc0Gmo43fpPx+IGWdKwkUrjA9AXD2aFef04PVl0F6 Wr4PM+4qoZ/u65a1QwY0yO3q1EBdm3elwjYEbQxsERBxoHJHaQ9QVUGshyr6VzV/PNrl h7TViiUu9cxdAD9lzN9m76U42skGhY8172AVo+DM4AOWXgwJfBimW+acolwxM/IOYOlB 3t5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HaDVUCfDbUysF1N7KhfteSFXd3S1ciSndfL6zXNrW9s=; b=C4Z3Ah36gHAwTtvAcz1rAhCBxceIU9TaZSR2iWyJWk5ys95ekiWANrYH5sOwVXQfBB ZegwiIzILlBKY3591XHPjAWPwIZ/QNoTeu9iy4MQ9eXz4hbaHAzDlI06FPRO1Ea70Lqk /j28CvRne4Mj2LKpQ6+KyCTFPZk/64Opb7Fiho8leieanHgFgXYVIo5IGKmuW7l7HaN+ hEYK43PhdP9tX35E/ZlHThCrdEKEe1Y5uA1N+tAYCgOG21ygCWIJYLSVisgsfPh6ffoV QWa4M2skohR/ZUO07LGgE5nPQ2BA4bn+yF43T7a+dJMzNXQpKqfUvfBha27lg27Sbh55 ZpIg== X-Gm-Message-State: AOAM5325Ho3dhebArsvV+ABjcqI7DEG4flj8n6irTq2o/73SNtGxm7vd iNrVwElxn3saFfKCcaASpvXFF6i2oWW4RTz8rrxeVw== X-Google-Smtp-Source: ABdhPJyJcXLghVfBEHfzy+3NU5FgOHAasQItJxw3SoimpnzwIgR0i+b8wcsczwTcwKrAd8L5fbzlKH8xAOJDzQTcU2o= X-Received: by 2002:a25:e0d4:: with SMTP id x203mr55309ybg.391.1630688980893; Fri, 03 Sep 2021 10:09:40 -0700 (PDT) MIME-Version: 1.0 References: <20210902230442.1515531-1-saravanak@google.com> <20210902230442.1515531-2-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 3 Sep 2021 10:09:05 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] of: platform: Make sure bus only devices get probed To: Geert Uytterhoeven Cc: Ulf Hansson , Rob Herring , Frank Rowand , Android Kernel Team , Linux Kernel Mailing List , DTML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Sep 3, 2021 at 7:29 AM Geert Uytterhoeven wrote: > > Hi Ulf, > > On Fri, Sep 3, 2021 at 11:19 AM Ulf Hansson wrote: > > On Fri, 3 Sept 2021 at 01:04, Saravana Kannan wrote: > > > fw_devlink could end up creating device links for bus only devices. > > > However, bus only devices don't get probed and can block probe() or > > > sync_state() [1] call backs of other devices. To avoid this, set up > > > these devices to get probed by the simple-pm-bus. > > > > > > [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/ > > > Signed-off-by: Saravana Kannan > > > Tested-by: Saravana Kannan > > > > Again, this looks like a nice solution to the problem. > > > > One question though. The Kconfig SIMPLE_PM_BUS, should probably be > > "default y" - or something along those lines to make sure fw_devlink > > works as expected. > > I would love for SIMPLE_PM_BUS to go away, and all of its functionality > to be usurped by the standard simple-bus handling. What if SIMPLE_PM_BUS *is* the standard simple-bus handling? Insert "I'm the captain now" meme. I think SIMPLE_PM_BUS config should just go away and we should compile the driver in if CONFIG_OF is selected. -Saravana