From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83237C433EF for ; Thu, 23 Jun 2022 08:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbiFWIEz (ORCPT ); Thu, 23 Jun 2022 04:04:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbiFWIEx (ORCPT ); Thu, 23 Jun 2022 04:04:53 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC67E473A6 for ; Thu, 23 Jun 2022 01:04:52 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id v81so34498181ybe.0 for ; Thu, 23 Jun 2022 01:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aJdGY8if0kKaADIOnNz/K5T0O1hT/jUoomceGsgv8qg=; b=VTQtFvKLR234TeEsJG9hJ1cv/fTlg/g75r8DUnXK6ZHcXDiNZlsJYB9CHo/M+MtXXm kHxKIuNF0rtlBZTftpqriI4HPVkNAF8Kgf2nEavzZoQhhOEgRbl56Yidg8QEwndgSNmo guDcAYV+JbY07aCqXNXOm0MAQ374EyPk3ywDSm8OW4cMFCwWkHtQXObbRqfIV1Au2qL/ 2xJX/OVUmoI0Ru+JwXOHrC9gjW8I3BqdmxJTIj+bkS/ZKg4cBj3SDMQZSf2iggQyehVV s0m81yWPr2B/Nu8wqEz2Z07cBjk9Ng0bbJAp4gpara4efxy5PPr9RgZdjjBJiDIEtWTH KYew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aJdGY8if0kKaADIOnNz/K5T0O1hT/jUoomceGsgv8qg=; b=pw1tOyzA5eJUFNi6DcXyo1ZGIAx3NjyobFOXSDN3a8jGYHjTkNWK2Mr/43fa2H6PZA YvkvEsYUCSuAE10jo+U5lfy9piKORTsYEGCIRSG66ol+WrccQ/IbTtX+6asbPObTlhcg tmJba25W5sibx8ioRv5DUKDtBAuAgiT5Jm3iAjVfIhyJkTqVoXQmxrgSYSI2Ch8Bwl6h o+rjCyILdqZnjsYFa6dM9LQFi2559xejWrI1pTYRjBShtFpI92ml02Sq+SBk2eBLzpsa k2KEp0O/GU8vzBfbssKCMpAppcE+HkpGMipBxaE1CXk6DSOg7UF6soSx0kGHlqJprta7 G2Ow== X-Gm-Message-State: AJIora8Egsrxu1GBbd/cZOs/X7FnACAC+xrv7VwLIXnRfi8bLWGJvPcs vKa/rZQb4CAIXcVfHPpmCS/dT+zmDaUth6Qmxr/xug== X-Google-Smtp-Source: AGRyM1vSa06Bo2VNf1pFNqSEQ2ygrs7ov2BN88IdRJyYwpujxiov2K55jHdtpFFoYamFYqbsbeU9U6O7j7pmqWeF7uU= X-Received: by 2002:a25:d8c8:0:b0:669:5f5b:7d75 with SMTP id p191-20020a25d8c8000000b006695f5b7d75mr8205442ybg.80.1655971491674; Thu, 23 Jun 2022 01:04:51 -0700 (PDT) MIME-Version: 1.0 References: <20220622215912.550419-1-saravanak@google.com> <20220622215912.550419-2-saravanak@google.com> <20220623065031.GX1615@pengutronix.de> In-Reply-To: <20220623065031.GX1615@pengutronix.de> From: Saravana Kannan Date: Thu, 23 Jun 2022 01:04:14 -0700 Message-ID: Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Allow firmware to mark devices as best effort To: Sascha Hauer Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Frank Rowand , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Peng Fan , Kevin Hilman , Ulf Hansson , Len Brown , Pavel Machek , Joerg Roedel , Will Deacon , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Hideaki YOSHIFUJI , David Ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@pengutronix.de, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jun 22, 2022 at 11:50 PM Sascha Hauer wrote: > > On Wed, Jun 22, 2022 at 02:59:10PM -0700, Saravana Kannan wrote: > > When firmware sets the FWNODE_FLAG_BEST_EFFORT flag for a fwnode, > > fw_devlink will do a best effort ordering for that device where it'll > > only enforce the probe/suspend/resume ordering of that device with > > suppliers that have drivers. The driver of that device can then decide > > if it wants to defer probe or probe without the suppliers. > > > > This will be useful for avoid probe delays of the console device that > > were caused by commit 71066545b48e ("driver core: Set > > fw_devlink.strict=1 by default"). > > > > Fixes: 71066545b48e ("driver core: Set fw_devlink.strict=1 by default") > > Reported-by: Sascha Hauer > > Reported-by: Peng Fan > > Signed-off-by: Saravana Kannan > > --- > > drivers/base/core.c | 3 ++- > > include/linux/fwnode.h | 4 ++++ > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/base/core.c b/drivers/base/core.c > > index 839f64485a55..61edd18b7bf3 100644 > > --- a/drivers/base/core.c > > +++ b/drivers/base/core.c > > @@ -968,7 +968,8 @@ static void device_links_missing_supplier(struct device *dev) > > > > static bool dev_is_best_effort(struct device *dev) > > { > > - return fw_devlink_best_effort && dev->can_match; > > + return (fw_devlink_best_effort && dev->can_match) || > > + dev->fwnode->flags & FWNODE_FLAG_BEST_EFFORT; > > Check for dev->fwnode first. I am running in a NULL pointer exception > here for a device that doesn't have a fwnode. Oops. Fixed and sent out a v2. -Saravana