devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alim Akhtar <alim.akhtar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Krzysztof Kozlowski
	<krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Javier Martinez Canillas
	<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	robh+dt <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	kgene <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sylwester Nawrocki
	<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	sanath-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
Date: Wed, 18 Jan 2017 22:40:42 +0900	[thread overview]
Message-ID: <CAGOxZ50aXxVitrgS6EXLbZdip0M7Xb0AwmSUvb7diVFVBK5OLw@mail.gmail.com> (raw)
In-Reply-To: <1484718141-28785-2-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> As per Exynos7 datasheet FSYS1 pinctrl block does not support drive
> strength value of 0x3. This patch fixes this and update the correct
> drive strength for sd0_xxx pin definitions.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> index 8232198..7ebb939 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> @@ -497,49 +497,49 @@
>                 samsung,pins = "gpr0-0";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_cmd: sd0-cmd {
>                 samsung,pins = "gpr0-1";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_ds: sd0-ds {
>                 samsung,pins = "gpr0-2";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <1>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_qrdy: sd0-qrdy {
>                 samsung,pins = "gpr0-3";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <1>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus1: sd0-bus-width1 {
>                 samsung,pins = "gpr1-0";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus4: sd0-bus-width4 {
>                 samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus8: sd0-bus-width8 {
>                 samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd1_clk: sd1-clk {
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-01-18 13:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170118053944epcas1p1bed1518b3ba444434bfbe4048b6fe4bd@epcas1p1.samsung.com>
2017-01-18  5:42 ` [PATCH 0/3] Use macros for pinctrl configuration on Exynos7 Pankaj Dubey
     [not found]   ` <CGME20170118053953epcas1p18e06184783a0edc6a2cfc3b6a9d9ce31@epcas1p1.samsung.com>
     [not found]     ` <1484718141-28785-1-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-18  5:42       ` [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions Pankaj Dubey
     [not found]         ` <1484718141-28785-2-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-18 13:40           ` Alim Akhtar [this message]
     [not found]   ` <CGME20170118054002epcas5p3b08e2f419976e17a3c584d64776810fd@epcas5p3.samsung.com>
2017-01-18  5:42     ` [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions Pankaj Dubey
     [not found]       ` <1484718141-28785-3-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-18 13:42         ` Alim Akhtar
2017-01-18 14:19       ` Krzysztof Kozlowski
2017-01-27 12:25         ` Sylwester Nawrocki
2017-01-27 14:41           ` Krzysztof Kozlowski
2017-02-01 12:51             ` Linus Walleij
2017-02-02 17:05               ` Krzysztof Kozlowski
     [not found]   ` <CGME20170118054013epcas5p3b20dca776ee350f4ba863db24d3dea67@epcas5p3.samsung.com>
2017-01-18  5:42     ` [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7 Pankaj Dubey
2017-01-18 13:43       ` Alim Akhtar
2017-01-18 15:01       ` Krzysztof Kozlowski
2017-01-20  3:19         ` pankaj.dubey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGOxZ50aXxVitrgS6EXLbZdip0M7Xb0AwmSUvb7diVFVBK5OLw@mail.gmail.com \
    --to=alim.akhtar-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=sanath-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).