devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alim Akhtar <alim.akhtar@gmail.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	devicetree@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	robh+dt <robh+dt@kernel.org>, kgene <kgene@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7
Date: Wed, 26 Nov 2014 19:03:46 +0530	[thread overview]
Message-ID: <CAGOxZ51P30BY2sOhUeMRK64CGF1fNcc-63RCXiAqZ6Rgpv3K7Q@mail.gmail.com> (raw)
In-Reply-To: <1416834177-11170-1-git-send-email-gautam.vivek@samsung.com>

Hi Vivek,

On Mon, Nov 24, 2014 at 6:32 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> USB and Power regulator on Exynos7 require gpios available
> in BUS1 pin controller block.
> So adding the BUS1 pinctrl support.
>
> Signed-off-by: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
Looks good to me.
Thanks!

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>
> This patch was part of series:
> "[PATCH 00/11] Exynos7: Adding USB 3.0 support"
>  https://lkml.org/lkml/2014/11/21/247
>
> Changes since V1:
>  - Added support for all pin banks which are part of BUS1 pin controller.
>
>  drivers/pinctrl/samsung/pinctrl-exynos.c |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
> index d5d4cfc..44e60dc 100644
> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
> @@ -1300,6 +1300,20 @@ static const struct samsung_pin_bank_data exynos7_pin_banks7[] __initconst = {
>         EXYNOS_PIN_BANK_EINTG(8, 0x060, "gpr3", 0x0c),
>  };
>
> +/* pin banks of exynos7 pin-controller - BUS1 */
> +static const struct samsung_pin_bank_data exynos7_pin_banks8[] __initconst = {
> +       EXYNOS_PIN_BANK_EINTG(8, 0x020, "gpf0", 0x00),
> +       EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpf1", 0x04),
> +       EXYNOS_PIN_BANK_EINTG(4, 0x060, "gpf2", 0x08),
> +       EXYNOS_PIN_BANK_EINTG(5, 0x080, "gpf3", 0x0c),
> +       EXYNOS_PIN_BANK_EINTG(8, 0x0a0, "gpf4", 0x10),
> +       EXYNOS_PIN_BANK_EINTG(8, 0x0c0, "gpf5", 0x14),
> +       EXYNOS_PIN_BANK_EINTG(5, 0x0e0, "gpg1", 0x18),
> +       EXYNOS_PIN_BANK_EINTG(5, 0x100, "gpg2", 0x1c),
> +       EXYNOS_PIN_BANK_EINTG(6, 0x120, "gph1", 0x20),
> +       EXYNOS_PIN_BANK_EINTG(3, 0x140, "gpv6", 0x24),
> +};
> +
>  const struct samsung_pin_ctrl exynos7_pin_ctrl[] __initconst = {
>         {
>                 /* pin-controller instance 0 Alive data */
> @@ -1342,5 +1356,10 @@ const struct samsung_pin_ctrl exynos7_pin_ctrl[] __initconst = {
>                 .pin_banks      = exynos7_pin_banks7,
>                 .nr_banks       = ARRAY_SIZE(exynos7_pin_banks7),
>                 .eint_gpio_init = exynos_eint_gpio_init,
> +       }, {
> +               /* pin-controller instance 8 BUS1 data */
> +               .pin_banks      = exynos7_pin_banks8,
> +               .nr_banks       = ARRAY_SIZE(exynos7_pin_banks8),
> +               .eint_gpio_init = exynos_eint_gpio_init,
>         },
>  };
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Regards,
Alim

  reply	other threads:[~2014-11-26 13:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 13:35 [PATCH 00/11] Exynos7: Adding USB 3.0 support Vivek Gautam
2014-11-21 13:35 ` [PATCH 01/11] pinctrl: exynos: Add BUS1 pin controller for exynos7 Vivek Gautam
2014-11-22 13:37   ` Alim Akhtar
2014-11-24  5:00     ` Vivek Gautam
2014-11-24 13:02       ` [PATCH V2 1/2] " Vivek Gautam
2014-11-26 13:33         ` Alim Akhtar [this message]
2014-11-28  3:35           ` Vivek Gautam
2014-11-28  3:39             ` Vivek Gautam
2014-11-28 15:45               ` Linus Walleij
2014-12-01 14:21                 ` Vivek Gautam
     [not found]                   ` <CAFp+6iHiC9mouT-v_yGHm5adDerCpT-s7EeWwwwYi-NzdLBnrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-03 13:41                     ` Linus Walleij
2014-12-01 16:07         ` Tomasz Figa
     [not found]           ` <CA+Ln22GHVinmpJccYYxNjYeApj3miy_zGMnWd8e5AOt0PCjh9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-10  8:21             ` Vivek Gautam
2014-11-21 13:35 ` [PATCH 02/11] dwc3: exynos: Remove local variable for clock from probe Vivek Gautam
     [not found] ` <1416576954-11997-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-21 13:35   ` [PATCH 03/11] dwc3: exynos: Add provision for suspend clock Vivek Gautam
2014-11-21 13:35   ` [PATCH 05/11] phy: exynos5-usbdrd: Add pipe-clk, utmi-clk and itp-clk support Vivek Gautam
2014-11-21 13:35   ` [PATCH 08/11] clk: exynos7: Add required clock tree for USB Vivek Gautam
2014-11-21 13:35 ` [PATCH 04/11] dwc3: exynos: Add provision for AXI UpScaler clock on exynos7 Vivek Gautam
2014-11-21 13:35 ` [PATCH 06/11] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply Vivek Gautam
2014-11-21 13:35 ` [PATCH 07/11] phy: exynos7-usbdrd: Update dependency for ARCH_EXYNOS Vivek Gautam
2014-11-21 13:35 ` [PATCH 09/11] arm64: exynos: Add bus1 pinctrl node on exynos7 Vivek Gautam
2014-11-22 13:41   ` Alim Akhtar
2014-11-24 13:06     ` [PATCH V2 2/2] " Vivek Gautam
     [not found]       ` <1416834381-11314-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-26 13:29         ` Alim Akhtar
2014-11-28  3:40           ` Vivek Gautam
2014-11-21 13:35 ` [PATCH 10/11] arm64: dts: Enable USB 3.0 controller " Vivek Gautam
2014-11-21 13:35 ` [PATCH 11/11] arm64: dts: exynos7-espresso: Add regulators for Vbus and Vbus-Boost Vivek Gautam
2014-11-21 15:11 ` [PATCH 00/11] Exynos7: Adding USB 3.0 support Felipe Balbi
2014-11-22  8:40   ` Kishon Vijay Abraham I
2014-11-22 15:12     ` Kukjin Kim
2014-11-25 11:48       ` Vivek Gautam
2014-12-22 14:47         ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGOxZ51P30BY2sOhUeMRK64CGF1fNcc-63RCXiAqZ6Rgpv3K7Q@mail.gmail.com \
    --to=alim.akhtar@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gautam.vivek@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).