From: Alim Akhtar <alim.akhtar@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Sylwester Nawrocki <snawrocki@kernel.org>,
stable@vger.kernel.org
Subject: Re: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250
Date: Thu, 6 Jan 2022 23:43:05 +0530 [thread overview]
Message-ID: <CAGOxZ52GgtkJ6RStGXik7PmMNfaisrqRojmsvQZWUPaNR8Qp+g@mail.gmail.com> (raw)
In-Reply-To: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com>
Hi Krzysztof
On Fri, Dec 31, 2021 at 4:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250,
> instead of proper pin gpa1-5.
>
> Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Thanks for fixing this.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index d31a68672bfa..d7d756614edd 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus {
> };
>
> uart3_data: uart3-data {
> - samsung,pins = "gpa1-4", "gpa1-4";
> + samsung,pins = "gpa1-4", "gpa1-5";
> samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> --
> 2.32.0
>
--
Regards,
Alim
next prev parent reply other threads:[~2022-01-06 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211230195340eucas1p1ebbcf10a6b4fb15fca9b7757af5e1702@eucas1p1.samsung.com>
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
2021-12-30 19:53 ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
2021-12-31 12:02 ` Krzysztof Kozlowski
2021-12-30 19:53 ` [RFT][PATCH 3/3] arm64: dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850 Krzysztof Kozlowski
2022-01-03 21:09 ` Sam Protsenko
2022-01-07 7:47 ` Krzysztof Kozlowski
2022-02-12 16:31 ` (subset) " Krzysztof Kozlowski
2022-01-06 18:13 ` Alim Akhtar [this message]
2022-01-10 22:20 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Marek Szyprowski
2022-01-23 17:10 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOxZ52GgtkJ6RStGXik7PmMNfaisrqRojmsvQZWUPaNR8Qp+g@mail.gmail.com \
--to=alim.akhtar@gmail.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=snawrocki@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).