From: Julian Calaby <julian.calaby@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com,
linux-mmc <linux-mmc@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: Convert the BCM4329 bindings to YAML and extend
Date: Mon, 15 Mar 2021 21:40:00 +1100 [thread overview]
Message-ID: <CAGRGNgUNzzHTre1oOjvV7-c-4mvjDuOAAmYRc4Nd_D6m+tLdPg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbHfH=+m3EJ9CBGkQ3rh6MGtKy4ixk3fgu15rxEzMg5dw@mail.gmail.com>
Hi Linus,
On Mon, Mar 15, 2021 at 10:43 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Sun, Mar 14, 2021 at 1:05 AM Julian Calaby <julian.calaby@gmail.com> wrote:
>
> > I don't know if this is necessary for SDIO, but should the non-4329
> > compatibles have the 4329 compatible as an alternative?
>
> I can, and I guess I should add it, as I grep:ed and saw this:
>
> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> compatible = "brcm,bcm4339-fmac", "brcm,bcm4329-fmac";
>
> So from more to less specific.
>
> Yours,
> Linus Walleij
If it helps, the pattern I've seen before for this is:
oneOf:
- const: vendor,specific-device-1234
- items:
- enum:
- vendor,compatible-device-2345
- vendor,compatible-device-3456
- const: vendor,specific-device-1234
See https://elixir.bootlin.com/linux/v5.12-rc3/source/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
for an example.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2021-03-15 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 21:53 [PATCH] dt-bindings: Convert the BCM4329 bindings to YAML and extend Linus Walleij
2021-03-14 0:05 ` Julian Calaby
2021-03-14 23:43 ` Linus Walleij
2021-03-15 10:40 ` Julian Calaby [this message]
2021-03-15 11:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGRGNgUNzzHTre1oOjvV7-c-4mvjDuOAAmYRc4Nd_D6m+tLdPg@mail.gmail.com \
--to=julian.calaby@gmail.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=devicetree@vger.kernel.org \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).