From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFCBC433E0 for ; Mon, 15 Mar 2021 10:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B83D064E99 for ; Mon, 15 Mar 2021 10:41:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbhCOKkf (ORCPT ); Mon, 15 Mar 2021 06:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbhCOKkN (ORCPT ); Mon, 15 Mar 2021 06:40:13 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE701C061574; Mon, 15 Mar 2021 03:40:12 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id lr13so65338292ejb.8; Mon, 15 Mar 2021 03:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DqzTiNwq7F43KRl7MeDTQAW5DfLX3HRrkcyj01ylqdg=; b=OAHm4NsI295ATwtqDJ6uWfMyjCp1UrvV1Os5KFJTwp8mV0pF0TJxhe+NYcMIYNKKHX xAxkXLUnteNgUGFYKjLHX7Owotbf98s3hFsrRFjlO4iK1exkBb7UL3QIsrDXWjTbIZi9 Sm2IflJgyHcnkuo9+cEtWy9YadMu7e840pufNuXSEym5LHB/unl/DnJU7SvW/9JpSYYK S2p5mO9jR9BlJMcBRPgZuskkVEnGE0I3h582BELwrOemv1x/hW6hchxEG7nm1UBwDeES c0oE+dj/5zgFkOtef9Hq9/Db1JvYQVWDrE1gU/N94ULNqTIUYRRx/KeVmwInA+sEax1b Oldg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DqzTiNwq7F43KRl7MeDTQAW5DfLX3HRrkcyj01ylqdg=; b=fBof9wcxbb8ReKcW4RRC9I9HlG+yJMab+UxHwovWW8gf6Iz0sFDihgKa5zWI6RGRAi OanFz+2YyU6T2O6C0hkst1c0Q0rzCTuuNm0FEcHlqLULmFcxgK4PZyhyWeXjsTaHCSi8 XrYD4FTN0IOrxCZGfm5IFMt1IzCbBz8BuIAsfdSw1mMBTSbyZXURSPbA2Jc5SIS0nrTl DFyrH+ZojIMu41fuQCOZRHL4vwM3uqoWlPLlzmMF3l8Zm++aVKKmuxN1CYAHdPS5oxmU EQSz76pTOQMnj6MgwPUafzPa1bkk5LuB9ofd3qBxVvpyZXxPXn/5XsTrLbRG1bRXPXx9 mCyA== X-Gm-Message-State: AOAM532oLVS76YWtR2LvgWu7/52SeLpMOkjzbxNE8z23YVeckX26As8x VRDSGWu4mVUNP9oaLL0Pi40AavZckVu384pCeA8= X-Google-Smtp-Source: ABdhPJyMTPKqLAPCgX5HECYtPHc584QK7Bo03u0+OSFE3M17en7cxnIzQqX+5hZ0KYbIC+jQn+YkMke4VpejGjHc66Y= X-Received: by 2002:a17:906:3849:: with SMTP id w9mr23036529ejc.7.1615804811719; Mon, 15 Mar 2021 03:40:11 -0700 (PDT) MIME-Version: 1.0 References: <20210313215302.4076765-1-linus.walleij@linaro.org> In-Reply-To: From: Julian Calaby Date: Mon, 15 Mar 2021 21:40:00 +1100 Message-ID: Subject: Re: [PATCH] dt-bindings: Convert the BCM4329 bindings to YAML and extend To: Linus Walleij Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , linux-wireless , brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, linux-mmc , devicetree Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Linus, On Mon, Mar 15, 2021 at 10:43 AM Linus Walleij wrote: > > On Sun, Mar 14, 2021 at 1:05 AM Julian Calaby wrote: > > > I don't know if this is necessary for SDIO, but should the non-4329 > > compatibles have the 4329 compatible as an alternative? > > I can, and I guess I should add it, as I grep:ed and saw this: > > arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > compatible = "brcm,bcm4339-fmac", "brcm,bcm4329-fmac"; > > So from more to less specific. > > Yours, > Linus Walleij If it helps, the pattern I've seen before for this is: oneOf: - const: vendor,specific-device-1234 - items: - enum: - vendor,compatible-device-2345 - vendor,compatible-device-3456 - const: vendor,specific-device-1234 See https://elixir.bootlin.com/linux/v5.12-rc3/source/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml for an example. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/