From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28066C433EF for ; Fri, 1 Jul 2022 05:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233640AbiGAFZP (ORCPT ); Fri, 1 Jul 2022 01:25:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232809AbiGAFZN (ORCPT ); Fri, 1 Jul 2022 01:25:13 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D276B21811 for ; Thu, 30 Jun 2022 22:25:12 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-31772f8495fso13306677b3.4 for ; Thu, 30 Jun 2022 22:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XTOOhYSz2Wo3skXNKI7YNt40yz1EYPv8kOg9CCS27tM=; b=OUVBm9UxYy8zUYolvkYKO2nN8kvaVrHfPshLWiz0dIbiqpLsnYO6NS8OQe7K61FvgG xlFLGudBSW9dFhmMZTMxw8rmKFA8aNvSEK+JjYGsDksY1MDQUtONRgS8zB9+Cq40w3GZ AkQXnp9ANfc3yECwFgfym9eIp0xkR7YYdxN48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XTOOhYSz2Wo3skXNKI7YNt40yz1EYPv8kOg9CCS27tM=; b=uAuXu8MkNANsW+KyVqIHaxx1ACVh8TrQufaEuHfPrYbRHXtxNDNwAYLl2FCwQTLI0D OEGH+Sv4nZmkuzIC6ii0yrrK+7wy1I7dSV2Gf2+M5hF1mAHcTjxQRVUgNIB0azxcOhm9 JgKSfKPT78JW7IfBd9fK6k+pEjzZinlXO5sjlLEQbsVGbC2Gq0QxXJfbEIAjPyF8PX4Z Zxp2/K90x0nLF7axLNB5HU5F3wEs/TP44HiKAdEvXN4V6BQGzFKCwqk5qPYMcz3Dr/sw ZvYEptbyqoqDoZNUSScth0BsIiwPjsKPS8QxtZEGlStBNConwiHfgGuow8xSN55Pm12N 0mVg== X-Gm-Message-State: AJIora+JKxs84o8/U0WCeiuQd5uesLKpiW3FwozYvJYsO8+KuOBaAFgV JfDyv6u/kMPncairkonNKwcoiRvZMYUgCmFGD5rm8w== X-Google-Smtp-Source: AGRyM1tzFRf+vWswFtN/NIUdUvvppuw3iV6XZTQB0jFpMstnBu/FE0ARw+3sZHiT20dCyvZqYsyn3NLnLK+W5NulKng= X-Received: by 2002:a81:19ca:0:b0:31b:732c:15e9 with SMTP id 193-20020a8119ca000000b0031b732c15e9mr14884710ywz.167.1656653112137; Thu, 30 Jun 2022 22:25:12 -0700 (PDT) MIME-Version: 1.0 References: <20220629121358.19458-1-allen-kh.cheng@mediatek.com> <20220629121358.19458-4-allen-kh.cheng@mediatek.com> <20220629232429.c5oysjgy6gflqhct@notapiano> <99342f13190cb4ea103c4227e6672eb5cad63b82.camel@mediatek.com> <20220630134210.7j665amh6tbeaecv@notapiano> In-Reply-To: <20220630134210.7j665amh6tbeaecv@notapiano> From: Chen-Yu Tsai Date: Fri, 1 Jul 2022 13:25:01 +0800 Message-ID: Subject: Re: [PATCH 3/5] arm64: dts: mt8192: Add display nodes To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: "allen-kh.cheng" , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 30, 2022 at 9:42 PM N=C3=ADcolas F. R. A. Prado wrote: > > On Thu, Jun 30, 2022 at 05:41:31PM +0800, allen-kh.cheng wrote: > > Hi N=C3=ADcolas, > > > > On Wed, 2022-06-29 at 19:24 -0400, N=C3=ADcolas F. R. A. Prado wrote: > > > On Wed, Jun 29, 2022 at 08:13:56PM +0800, Allen-KH Cheng wrote: > > > > Add display nodes and gce info for mt8192 SoC. > > > > > > > > GCE (Global Command Engine) properties to the display nodes in > > > > order to > > > > enable the usage of the CMDQ (Command Queue), which is required for > > > > operating the display. > > > > > > > > Signed-off-by: Allen-KH Cheng > > > > Reviewed-by: AngeloGioacchino Del Regno < > > > > angelogioacchino.delregno@collabora.com> > > > > --- > > > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 136 > > > > +++++++++++++++++++++++ > > > > 1 file changed, 136 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > index a07edc82d403..26d01544b4ea 100644 > > > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > [..] > > > > + rdma0: rdma@14007000 { > > > > + compatible =3D "mediatek,mt8192-disp-rdma"; > > > > > > dtbs_check is complaining that there isn't a "mediatek,mt8183-disp- > > > rdma" > > > fallback compatible here. But given that the rdma driver matches > > > directly to the > > > mt8192 compatible, I think the node here is fine, and the binding is > > > the one > > > that should be updated. > > > > > > > I have checked the binding and driver again. > > > > I prefer use "mediatek,mt8186-disp-rdma" as fallback and remove mt8192 > > compatible and data in mtk_disp_rdma.c because they are the same with > > mt8183. > > > > Do you think it is okay? > > Sure, that sounds good to me as well. That's backwards. MT8192 was released well before MT8186. The latter hasn't even hit the market yet. Please use "mediatek,mt8183-disp-rdma" as fallback. And you need to keep "mediatek,mt8192-disp-rdma" as the most specific compatible string, because we want SoC specific compatible strings. For the driver, there isn't any difference between mt8183 and mt8192 for the rdma part, so we might as well just remove the mt8192 compatible from the driver. Regards ChenYu