From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9106C433EF for ; Mon, 21 Feb 2022 04:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343964AbiBUEum (ORCPT ); Sun, 20 Feb 2022 23:50:42 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343601AbiBUEul (ORCPT ); Sun, 20 Feb 2022 23:50:41 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 962E7517EC for ; Sun, 20 Feb 2022 20:50:19 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id g6so10452064ybe.12 for ; Sun, 20 Feb 2022 20:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6fLPreDyk5i/acRhp6t4wYyRKGMfEFw6AWmQFjTT3XM=; b=lcJRQC48zBT6JSk4Cze0rWSvfDcjxUrksvEdhCPEJ9kcKeuCJ8ZTqkOMFnVW9fN4LL 7kfPRB7tL3AI9stSJYhk2gAYt+K6CgL7KBgSaqC4QmR2ucTci0NCQzyiVDmCf+5V0krp PJacX78nweK6yTgCJE0Lz5jgZZdPJe7gbORvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6fLPreDyk5i/acRhp6t4wYyRKGMfEFw6AWmQFjTT3XM=; b=CcFB7B/ng0/l7jmuKupwLyllCMVgun0m3amUPV3WhwAkzGcwhrtKnjTxA2RpTc3Oce P18zLqLhULzv4pXRQre0lMcOpEnY7fciE1VJ9RfvCiHiE6HXWHrDgXw+NtxFklIu0ywS qvHyMKV1ejY4lfV0hSkntSoukPKA5Y/lOm8WqUI4LClZqxN/FTqdMsWbDBVKOyHnoxM2 OZXejuKVVEPp0xor1ezeyMtgBzBlEquSX54W45PdoXAy2XaaBtqw76i+xjDuJ5AEi5qG w/v++rqtZjb+a529qvKXb9/JZh4oEhdUNm9/JXhuyRc4Kr0dpvLojxdWikoMLyqAq22O Q5dg== X-Gm-Message-State: AOAM532QXFZBCvdP9J+jkQYMYcHBX5xE8db9UoAEIydldaJISusX1Y7g g44fWdPQOw5a2F3sRcyzSjmDUntWd/KVx4AHvfoDog== X-Google-Smtp-Source: ABdhPJwnJji3Y6vGfmHdiJMJSvQXhmnzkIuuJoCGVqZQWmEi5cZKBvn6o1cT2ydL5KK4nhZsMh8eNWrzvt2qMHhyDxg= X-Received: by 2002:a25:2d52:0:b0:624:1bf8:2f8 with SMTP id s18-20020a252d52000000b006241bf802f8mr16376975ybe.219.1645419018711; Sun, 20 Feb 2022 20:50:18 -0800 (PST) MIME-Version: 1.0 References: <20220218091633.9368-1-allen-kh.cheng@mediatek.com> <20220218091633.9368-20-allen-kh.cheng@mediatek.com> In-Reply-To: <20220218091633.9368-20-allen-kh.cheng@mediatek.com> From: Chen-Yu Tsai Date: Mon, 21 Feb 2022 12:50:08 +0800 Message-ID: Subject: Re: [PATCH v2 19/23] arm64: dts: mt8192: Add i2c aliases To: Allen-KH Cheng Cc: Matthias Brugger , Rob Herring , "--to=Krzysztof Kozlowski" , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Ryder Lee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Fri, Feb 18, 2022 at 5:16 PM Allen-KH Cheng wrote: > > Add i2c aliases for mt8192 SoC > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 55bcbf72a366..e3314cdc7c1a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -21,6 +21,19 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > + i2c9 = &i2c9; AFAIK, maintainers have suggested against [1] having aliases in the .dtsi. If the numbering isn't an issue, I suggest just dropping it altogether. If it is, then the aliases should be added at the board level, and only for the interfaces that are actually enabled. ChenYu [1] https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@mail.gmail.com/ > + }; > + > clk26m: oscillator0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > -- > 2.18.0 >