From: Chen-Yu Tsai <wenst@chromium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: linux-mediatek@lists.infradead.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH 2/2] arm: dts: mediatek: Declare drive-strength numerically
Date: Thu, 20 Jun 2024 18:19:56 +0800 [thread overview]
Message-ID: <CAGXv+5GLCrQzxGFSuReD77CLBa-w4=1So8qdbPm_1nohKOOnpw@mail.gmail.com> (raw)
In-Reply-To: <20240620101656.1096374-3-angelogioacchino.delregno@collabora.com>
On Thu, Jun 20, 2024 at 6:17 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> On some devicetrees, the drive-strength property gets assigned a
> MTK_DRIVE_(x)_mA definition, which matches with (x).
>
> For example, MTK_DRIVE_8mA equals to 8 and MTK_DRIVE_30mA equals
> to 30.
>
> Also keeping in mind that the drive-strength property is, by
> (binding) definition, taking a number in milliamperes unit,
> change all devicetrees to avoid the usage of any MTK_DRIVE_(x)
> definition.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> arch/arm/boot/dts/mediatek/mt2701-evb.dts | 2 +-
> arch/arm/boot/dts/mediatek/mt7623.dtsi | 18 +++++++++---------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mediatek/mt2701-evb.dts b/arch/arm/boot/dts/mediatek/mt2701-evb.dts
> index 9c7325f18933..4c76366aa938 100644
> --- a/arch/arm/boot/dts/mediatek/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mediatek/mt2701-evb.dts
> @@ -231,7 +231,7 @@ pins1 {
> <MT2701_PIN_238_EXT_SDIO1__FUNC_EXT_SDIO1>,
> <MT2701_PIN_237_EXT_SDIO2__FUNC_EXT_SDIO2>,
> <MT2701_PIN_236_EXT_SDIO3__FUNC_EXT_SDIO3>;
> - drive-strength = <MTK_DRIVE_4mA>;
> + drive-strength = <4>;
> bias-pull-up;
> };
> };
> diff --git a/arch/arm/boot/dts/mediatek/mt7623.dtsi b/arch/arm/boot/dts/mediatek/mt7623.dtsi
> index f0b4a09004b3..814586abc297 100644
> --- a/arch/arm/boot/dts/mediatek/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt7623.dtsi
> @@ -1143,13 +1143,13 @@ pins-cmd-dat {
> <MT7623_PIN_121_MSDC0_DAT0_FUNC_MSDC0_DAT0>,
> <MT7623_PIN_116_MSDC0_CMD_FUNC_MSDC0_CMD>;
> input-enable;
> - drive-strength = <MTK_DRIVE_2mA>;
> + drive-strength = <2>;
> bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
> };
>
> pins-clk {
> pinmux = <MT7623_PIN_117_MSDC0_CLK_FUNC_MSDC0_CLK>;
> - drive-strength = <MTK_DRIVE_2mA>;
> + drive-strength = <2>;
> bias-pull-down = <MTK_PUPD_SET_R1R0_01>;
> };
>
> @@ -1167,14 +1167,14 @@ pins-cmd-dat {
> <MT7623_PIN_110_MSDC1_DAT3_FUNC_MSDC1_DAT3>,
> <MT7623_PIN_105_MSDC1_CMD_FUNC_MSDC1_CMD>;
> input-enable;
> - drive-strength = <MTK_DRIVE_4mA>;
> + drive-strength = <4>;
> bias-pull-up = <MTK_PUPD_SET_R1R0_10>;
> };
>
> pins-clk {
> pinmux = <MT7623_PIN_106_MSDC1_CLK_FUNC_MSDC1_CLK>;
> bias-pull-down;
> - drive-strength = <MTK_DRIVE_4mA>;
> + drive-strength = <4>;
> };
>
> pins-wp {
> @@ -1197,13 +1197,13 @@ pins-cmd-dat {
> <MT7623_PIN_110_MSDC1_DAT3_FUNC_MSDC1_DAT3>,
> <MT7623_PIN_105_MSDC1_CMD_FUNC_MSDC1_CMD>;
> input-enable;
> - drive-strength = <MTK_DRIVE_4mA>;
> + drive-strength = <4>;
> bias-pull-up = <MTK_PUPD_SET_R1R0_10>;
> };
>
> pins-clk {
> pinmux = <MT7623_PIN_106_MSDC1_CLK_FUNC_MSDC1_CLK>;
> - drive-strength = <MTK_DRIVE_4mA>;
> + drive-strength = <4>;
> bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
> };
> };
> @@ -1211,7 +1211,7 @@ pins-clk {
> nand_pins_default: nanddefault {
> pins-ale {
> pinmux = <MT7623_PIN_116_MSDC0_CMD_FUNC_NALE>;
> - drive-strength = <MTK_DRIVE_8mA>;
> + drive-strength = <8>;
> bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
> };
>
> @@ -1226,13 +1226,13 @@ pins-dat {
> <MT7623_PIN_115_MSDC0_RSTB_FUNC_NLD8>,
> <MT7623_PIN_119_MSDC0_DAT2_FUNC_NLD2>;
> input-enable;
> - drive-strength = <MTK_DRIVE_8mA>;
> + drive-strength = <8>;
> bias-pull-up;
> };
>
> pins-we {
> pinmux = <MT7623_PIN_117_MSDC0_CLK_FUNC_NWEB>;
> - drive-strength = <MTK_DRIVE_8mA>;
> + drive-strength = <8>;
> bias-pull-up = <MTK_PUPD_SET_R1R0_10>;
> };
> };
> --
> 2.45.2
>
>
prev parent reply other threads:[~2024-06-20 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 10:16 [PATCH 0/2] dts: mediatek: Stop using unneeded definitions AngeloGioacchino Del Regno
2024-06-20 10:16 ` [PATCH 1/2] arm64: dts: mediatek: Declare drive-strength numerically AngeloGioacchino Del Regno
2024-06-20 10:21 ` Chen-Yu Tsai
2024-06-20 10:16 ` [PATCH 2/2] arm: " AngeloGioacchino Del Regno
2024-06-20 10:19 ` Chen-Yu Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXv+5GLCrQzxGFSuReD77CLBa-w4=1So8qdbPm_1nohKOOnpw@mail.gmail.com' \
--to=wenst@chromium.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).