From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150A1C54EBD for ; Mon, 9 Jan 2023 11:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234085AbjAILdj (ORCPT ); Mon, 9 Jan 2023 06:33:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234066AbjAILdj (ORCPT ); Mon, 9 Jan 2023 06:33:39 -0500 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09AF7186D2 for ; Mon, 9 Jan 2023 03:33:35 -0800 (PST) Received: by mail-vs1-xe31.google.com with SMTP id i185so8243609vsc.6 for ; Mon, 09 Jan 2023 03:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZSDXftrDLJQK7xmJBG2ELgbyinIOI/n7lmtYUtA57Fs=; b=bJJlCRQwZSRuqt1LoaMGKivf6A9fZ9rncAVmVob2q/Y2tEtiIA0bNy6vg8QZlbay+P FaJc1wxuWpfDSwrzS8kdrpnt9CQr66M9legLAKRVqhxAUd0IrAS/Zzc7snKW2DWOEMlN ybx/0SzQhIM6t1ARC1R98cssk90pNC/RqJO98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZSDXftrDLJQK7xmJBG2ELgbyinIOI/n7lmtYUtA57Fs=; b=GfuHz6Y0YIxrOwN1N+FCVSpohzMOUO7ovoQerS0CEci4dy7MjfQ2UojfnD/PN0U8qA qBQO94R8D+90sTjxlWjfvhdqLpVwQLIR9eBTtbfSeIDoSqKXWD3x3psyTJZ4P72+noqB NUr/WjwC8wC4aONVltPQrswgeOrBnuem5LaQy0agxQfrvLDd9P+xl+F/On7u7TrAPaqJ b6iiFoBgZuiyksVNv7JSg+Qe7q2d1TX2cG1SO6DUCC/I49vgYo7HG1lU05KugbbgP8fL 45JuPfNOR2PmuZUn0gfawtJv/deKwSjDPnP2Jf1GoIXAU9ht0h+4qiVuK+9qm+XtLbFR o5yg== X-Gm-Message-State: AFqh2kr/pX7o5SIZlSEBlUcI72zT78V7xcl+rL86nRn2IgjFYtgtTLNM LUH5YdIxcOp3PCA0qlIG3pyQgcewOxM3oCoYt3Sciw== X-Google-Smtp-Source: AMrXdXuKLBlCyhGQkkUkLWKlzTLcYAo/jHsHe7IlF4q1WX5pDRdIAXdOYMK/bZk42xpiZYdtx3FQv038aJ+bvpjmxTA= X-Received: by 2002:a67:447:0:b0:3ce:d0ae:f6f6 with SMTP id 68-20020a670447000000b003ced0aef6f6mr3016990vse.26.1673264014106; Mon, 09 Jan 2023 03:33:34 -0800 (PST) MIME-Version: 1.0 References: <20230109084101.265664-1-treapking@chromium.org> <20230109084101.265664-4-treapking@chromium.org> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 9 Jan 2023 19:33:22 +0800 Message-ID: Subject: Re: [PATCH v9 3/9] drm/display: Add Type-C switch helpers To: Pin-yen Lin Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marek Vasut , chrome-platform@lists.linux.dev, Javier Martinez Canillas , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Kees Cook , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Jani Nikula , Allen Chen , Stephen Boyd , Hsin-Yi Wang , Xin Ji , AngeloGioacchino Del Regno , Douglas Anderson , Thomas Zimmermann Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 9, 2023 at 6:10 PM Chen-Yu Tsai wrote: > > On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices. > > > > The helper registers USB Type-C mode switches when the "mode-switch" > > and the "data-lanes" properties are available in Device Tree. > > > > Signed-off-by: Pin-yen Lin > > Tested-by: Chen-Yu Tsai > > on MT8192 based Hayato (ASUS Chromebook Flip CM3200). > > > --- > > > > (no changes since v8) > > > > Changes in v8: > > - Fixed the build issue when CONFIG_TYPEC=m > > - Fixed some style issues > > > > Changes in v7: > > - Extracted the common codes to a helper function > > - New in v7 > > > > drivers/gpu/drm/display/drm_dp_helper.c | 132 ++++++++++++++++++++++++ > > include/drm/display/drm_dp_helper.h | 16 +++ > > 2 files changed, 148 insertions(+) > > > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c > > index 16565a0a5da6..fb9e23744c08 100644 > > --- a/drivers/gpu/drm/display/drm_dp_helper.c > > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > > @@ -30,11 +30,13 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -3891,3 +3893,133 @@ int drm_panel_dp_aux_backlight(struct drm_panel *panel, struct drm_dp_aux *aux) > > EXPORT_SYMBOL(drm_panel_dp_aux_backlight); > > > > #endif > > + > > +#if IS_REACHABLE(CONFIG_TYPEC) > > +static int drm_dp_register_mode_switch(struct device *dev, struct device_node *node, > > + struct drm_dp_typec_switch_desc *switch_desc, > > + void *data, void *mux_set) Using "typec_mux_set_fn_t" instead of "void *" for mux_set would be more explicit. Same for all the other instances where this parameter gets declared. ChenYu > > +{ > > + struct drm_dp_typec_port_data *port_data; > > + struct typec_mux_desc mux_desc = {}; > > + char name[32]; > > + u32 dp_lanes[2]; > > + int ret, num_lanes, port_num = -1; > > + > > + num_lanes = drm_of_get_data_lanes_count(node, 0, 2); > > + if (num_lanes <= 0) { > > + dev_err(dev, "Error on getting data lanes count: %d\n", > > + num_lanes); > > Also printing out the full node name (endpoint@N) would be more helpful. > > > + return num_lanes; > > + } > > + > > + ret = of_property_read_u32_array(node, "data-lanes", dp_lanes, num_lanes); > > + if (ret) { > > + dev_err(dev, "Failed to read the data-lanes variable: %d\n", > > + ret); > > Same here. > > > + return ret; > > + } > > + > > + port_num = dp_lanes[0] / 2; > > + > > + port_data = &switch_desc->typec_ports[port_num]; > > + port_data->data = data; > > + mux_desc.fwnode = &node->fwnode; > > + mux_desc.drvdata = port_data; > > + snprintf(name, sizeof(name), "%s-%u", node->name, port_num); > > + mux_desc.name = name; > > + mux_desc.set = mux_set; > > + > > + port_data->typec_mux = typec_mux_register(dev, &mux_desc); > > + if (IS_ERR(port_data->typec_mux)) { > > + ret = PTR_ERR(port_data->typec_mux); > > + dev_err(dev, "Mode switch register for port %d failed: %d\n", > > + port_num, ret); > > + } > > + > > + return ret; > > +} > > + > > +/** > > + * drm_dp_register_typec_switches() - register Type-C switches > > + * @dev: Device that registers Type-C switches > > + * @port: Device node for the switch > > + * @switch_desc: A Type-C switch descriptor > > + * @data: Private data for the switches > > + * @mux_set: Callback function for typec_mux_set > > + * > > + * This function registers USB Type-C switches for DP bridges that can switch > > + * the output signal between their output pins. > > + * > > + * Currently only mode switches are implemented, and the function assumes the > > + * given @port device node has endpoints with "mode-switch" property. > > + * Register the endpoint as port 0 if the "data-lanes" property falls in 0/1, > > + * and register it as port 1 if "data-lanes" falls in 2/3. > > + */ > > +int drm_dp_register_typec_switches(struct device *dev, struct device_node *port, > > + struct drm_dp_typec_switch_desc *switch_desc, > > + void *data, void *mux_set) > > +{ > > + struct device_node *sw; > > + int ret; > > + > > + for_each_child_of_node(port, sw) { > > + if (of_property_read_bool(sw, "mode-switch")) > > + switch_desc->num_typec_switches++; > > + } > > + > > + if (!switch_desc->num_typec_switches) { > > + dev_warn(dev, "No Type-C switches node found\n"); > > Maybe change this to dev_info or even dev_debug? A warning would be too > noisy if the bridge drivers are calling this helper unconditionally. > > Otherwise, > > Reviewed-by: Chen-Yu Tsai