From: Kyle Tso <kyletso@google.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg KH <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
robh+dt@kernel.org, Badhri Jagan Sridharan <badhri@google.com>,
USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] usb: typec: Determine common SVDM Versions
Date: Tue, 2 Feb 2021 16:37:00 +0800 [thread overview]
Message-ID: <CAGZ6i=0Csdfy0Z-608HsX1YLBPiAz7qindF5SdTXv0yoNu7DYA@mail.gmail.com> (raw)
In-Reply-To: <20210201153542.GH2465@kuha.fi.intel.com>
On Mon, Feb 1, 2021 at 11:35 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Mon, Feb 01, 2021 at 09:34:19PM +0800, Kyle Tso wrote:
> > PD Spec Revision 3.0 Version 2.0 + ECNs 2020-12-10
> > 6.4.4.2.3 Structured VDM Version
> > "The Structured VDM Version field of the Discover Identity Command
> > sent and received during VDM discovery Shall be used to determine the
> > lowest common Structured VDM Version supported by the Port Partners or
> > Cable Plug and Shall continue to operate using this Specification
> > Revision until they are Detached."
> >
> > Also clear the fields newly defined in SVDM version 2.0 for
> > compatibilities. And fix some VDO definitions changed in the Spec.
> >
> > Signed-off-by: Kyle Tso <kyletso@google.com>
> > ---
> > Changes since v2:
> > - rename the variable and the functions (remove the text "common")
> > - remove the macro
> >
> > drivers/usb/typec/altmodes/displayport.c | 8 +-
> > drivers/usb/typec/class.c | 21 +-
> > drivers/usb/typec/tcpm/tcpm.c | 47 +++-
> > drivers/usb/typec/ucsi/displayport.c | 12 +-
> > drivers/usb/typec/ucsi/ucsi.c | 2 +
> > include/linux/usb/pd_vdo.h | 315 +++++++++++++++++------
> > include/linux/usb/typec.h | 10 +
> > 7 files changed, 326 insertions(+), 89 deletions(-)
>
> I think there is some room to split this one at least a little. The
> changes to the class (so drivers/usb/typec/class.c and
> include/linux/usb/typec.h) could be introduced separately at least.
>
> So I see there are two changes in this patch. You are modifying the
> class, and then there are the updated PD definitions. Both should be
> introduced in separate patches IMO. I think also each driver (so
> ucsi.c and tcpm.c) can handle the changes to the class in its own
> patch. The modifications to the PD definitions and updated VDO() and
> so on can be handled in a single patch I guess.
>
I will separate this patch to different ones.
thanks,
Kyle
>
> thanks,
>
> --
> heikki
next prev parent reply other threads:[~2021-02-02 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 13:34 [PATCH v3 0/3] common SVDM version and VDO from dt Kyle Tso
2021-02-01 13:34 ` [PATCH v3 1/3] usb: typec: Determine common SVDM Versions Kyle Tso
2021-02-01 15:04 ` Guenter Roeck
2021-02-01 15:35 ` Heikki Krogerus
2021-02-02 8:37 ` Kyle Tso [this message]
2021-02-01 13:34 ` [PATCH v3 2/3] dt-bindings: connector: Add SVDM VDO properties Kyle Tso
2021-02-01 13:34 ` [PATCH v3 3/3] usb: typec: tcpm: Get Sink VDO from fwnode Kyle Tso
2021-02-01 15:04 ` Guenter Roeck
2021-02-02 8:22 ` Heikki Krogerus
2021-02-01 15:05 ` [PATCH v3 0/3] common SVDM version and VDO from dt Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ6i=0Csdfy0Z-608HsX1YLBPiAz7qindF5SdTXv0yoNu7DYA@mail.gmail.com' \
--to=kyletso@google.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).