devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
Date: Thu, 24 Apr 2014 16:21:50 -0700	[thread overview]
Message-ID: <CAGa+x84uPwuUC61S4Wi2ymSdxVMs14pb_kCv0RhQRi-KySxSAw@mail.gmail.com> (raw)
In-Reply-To: <7hiopynyt5.fsf@paris.lan>

On Thu, Apr 24, 2014 at 3:32 PM, Kevin Hilman <khilman@linaro.org> wrote:
> Robert Nelson <robertcnelson@gmail.com> writes:
>
>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>>
>> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
>> ---
>>  arch/arm/boot/dts/Makefile               |  1 +
>>  arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
>>  2 files changed, 16 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 35c146f..0bdeba3 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>>       omap3-sbc-t3730.dtb \
>>       omap3-devkit8000.dtb \
>>       omap3-beagle-xm.dtb \
>> +     omap3-beagle-xm-ab.dtb \
>>       omap3-evm.dtb \
>>       omap3-evm-37xx.dtb \
>>       omap3-ldp.dtb \
>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> new file mode 100644
>> index 0000000..9d81123
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> @@ -0,0 +1,15 @@
>> +/*
>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include "omap3-beagle-xm.dts"
>> +
>> +/ {
>> +     /* HS USB Port 2 Power enable was inverted with the xM C */
>> +     hsusb2_power: hsusb2_power_reg {
>> +             enable-active-high;
>
> Missing '};' here?
>
> This causes build breakage in linux-omap master, which now has this
> applied.

ignore this.  It's already been fixed, but was still lingering in
Tony's master branch.

Kevin

  reply	other threads:[~2014-04-24 23:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 15:09 [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B Robert Nelson
2014-04-15 15:12 ` Robert Nelson
2014-04-15 15:35   ` Nishanth Menon
2014-04-15 15:40     ` Robert Nelson
     [not found]       ` <CAOCHtYhygGFbUunY9abEkjKfpQ1hh-DfRfhm160NehSYhWJSRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-18 22:51         ` Tony Lindgren
2014-04-18 23:42           ` Robert Nelson
2014-04-18 23:51             ` Tony Lindgren
2014-04-22  6:49               ` Gupta, Pekon
2014-04-22 14:03                 ` Tony Lindgren
2014-04-24 22:34                   ` Kevin Hilman
2014-04-24 22:32 ` Kevin Hilman
2014-04-24 23:21   ` Kevin Hilman [this message]
2014-04-24 23:37     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGa+x84uPwuUC61S4Wi2ymSdxVMs14pb_kCv0RhQRi-KySxSAw@mail.gmail.com \
    --to=khilman@linaro.org \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robertcnelson@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).