devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-doc@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Tomasz Figa <t.figa@samsung.com>,
	Will Deacon <will.deacon@arm.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Paul Mackerras <paulus@samba.org>, Arnd Bergmann <arnd@arndb.de>,
	Josh Cartwright <joshc@codeaurora.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Grant Likely <grant.likely@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Laura Abbott <lauraa@codeaurora.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Michal Nazarewicz <mina86@mina86.com>,
	linaro-mm-sig@lists.linaro.org, Marc <marc.ceeeee@gmail.com>,
	Nishanth Peethambaran <nishanth.p@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.in>
Subject: Re: [PATCH v5 09/11] arm: add support for reserved memory defined by device tree
Date: Thu, 13 Mar 2014 13:46:50 -0700	[thread overview]
Message-ID: <CAGa+x856+YyJ-vyfGoFAKmsqwKD+=Wh0-TT_mAaPStOXjd8eSQ@mail.gmail.com> (raw)
In-Reply-To: <1392985527-6260-10-git-send-email-m.szyprowski@samsung.com>

On Fri, Feb 21, 2014 at 4:25 AM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Enable reserved memory initialization from device tree.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

This patch has hit -next and several legacy (non-DT) boot failures
were detected and bisected down to this patch.  A quick scan looks
like there needs to be some sanity checking whether a DT is even
present.

Kevin

[1] http://lists.linaro.org/pipermail/kernel-build-reports/2014-March/002791.html

>  arch/arm/Kconfig   |    1 +
>  arch/arm/mm/init.c |    2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e25419817791..d0262bea8020 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1918,6 +1918,7 @@ config USE_OF
>         select IRQ_DOMAIN
>         select OF
>         select OF_EARLY_FLATTREE
> +       select OF_RESERVED_MEM
>         help
>           Include support for flattened device tree machine descriptions.
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 804d61566a53..2a77ba8796ae 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -323,6 +323,8 @@ void __init arm_memblock_init(struct meminfo *mi,
>         if (mdesc->reserve)
>                 mdesc->reserve();
>
> +       early_init_fdt_scan_reserved_mem();
> +
>         /*
>          * reserve memory for DMA contigouos allocations,
>          * must come from DMA area inside low memory
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2014-03-13 20:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 12:25 [PATCH v5 00/11] reserved-memory regions/CMA in devicetree, again Marek Szyprowski
     [not found] ` < 1392985527-6260-7-git-send-email-m.szyprowski@samsung.com>
     [not found] ` < 1392985527-6260-10-git-send-email-m.szyprowski@samsung.com>
     [not found]   ` < CAGa+x856+YyJ-vyfGoFAKmsqwKD+=Wh0-TT_mAaPStOXjd8eSQ@mail.gmail.com>
     [not found] ` < 1392985527-6260-2-git-send-email-m.szyprowski@samsung.com>
2014-02-21 12:25 ` [PATCH v5 01/11] of: document bindings for reserved-memory nodes Marek Szyprowski
2014-02-26 11:51   ` Grant Likely
2014-02-28  9:54     ` Marek Szyprowski
2014-02-28 10:01       ` Tomasz Figa
     [not found]       ` <53105CC6.1090902-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-01 19:58         ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 02/11] drivers: of: add initialization code for static reserved memory Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 03/11] drivers: of: add initialization code for dynamic " Marek Szyprowski
2014-02-26 12:09   ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 04/11] drivers: of: add support for custom reserved memory drivers Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 05/11] drivers: of: add automated assignment of reserved regions to client devices Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 06/11] drivers: of: initialize and assign reserved memory to newly created devices Marek Szyprowski
2014-02-26 12:14   ` Grant Likely
2014-02-27 10:10     ` Marek Szyprowski
2014-03-01 20:20       ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 07/11] drivers: dma-coherent: add initialization from device tree Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 08/11] drivers: dma-contiguous: " Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 09/11] arm: add support for reserved memory defined by " Marek Szyprowski
2014-03-13 20:46   ` Kevin Hilman [this message]
2014-03-13 21:36     ` Josh Cartwright
2014-03-13 21:51       ` Kevin Hilman
2014-03-15 13:07         ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 10/11] arm64: " Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 11/11] powerpc: " Marek Szyprowski
     [not found] ` < 1392985527-6260-3-git-send-email-m.szyprowski@samsung.com>
     [not found]   ` <1392985527-6260-3-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-02-26 12:05     ` [PATCH v5 02/11] drivers: of: add initialization code for static reserved memory Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGa+x856+YyJ-vyfGoFAKmsqwKD+=Wh0-TT_mAaPStOXjd8eSQ@mail.gmail.com' \
    --to=khilman@linaro.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=joshc@codeaurora.org \
    --cc=lauraa@codeaurora.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.in \
    --cc=linux-doc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marc.ceeeee@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mina86@mina86.com \
    --cc=nishanth.p@gmail.com \
    --cc=paulus@samba.org \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=swarren@wwwdotorg.org \
    --cc=t.figa@samsung.com \
    --cc=tomasz.figa@gmail.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).