From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board Date: Mon, 13 Jun 2016 11:01:53 +0800 Message-ID: References: <20160602023623.5761-1-luoyi.ly@gmail.com> <20160602081638.GG4908@lukather> <574FF94B.3020309@web.de> <20160610093851.GQ5242@lukather> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160610093851.GQ5242@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Chen-Yu Tsai , Bernhard Nortmann , Julian Calaby , =?UTF-8?B?572X57+8?= , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree , "Mailing List, Arm" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: devicetree@vger.kernel.org On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard wrote: > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote: >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard: >> >[...] >> >Yes, everything that is shared with the banana-pro (which, judging >> >from Bernhard, is pretty much everything but a GPIO) should be merged >> >in the banapro DT. >> > >> >Maxime >> > >> >> Don't take my word for granted, as I do not own this hardware or know it >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are >> very similar, but if in doubt the information form the wiki should be >> verified. > > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much > more than I do. I did a comparison of the "Banana Pro" vs the "BPi-M1+". The differences are similar to what we have with any other development board, say the Cubietruck: - A different WiFi chip is used, and the BT part is not hooked up. - Different GPIOs for external power regulator/switches - Different GPIOs for LEDs - Different peripherals exposed on the headers. IMO There's no need to merge or have a common .dtsi for the two boards. They (and all the other development boards) look similar because everyone is following the basic set by Allwinner's reference design, like which MMC controller and pins are used for SD/MMC, which ones are used for SDIO-based WiFi, and so on. I did a version completely from scratch using just the schematics: https://github.com/wens/linux/commits/bpi-m1-plus Please ignore the last commit. It's just me playing with NTP support for GPS time. Regards ChenYu